-
Notifications
You must be signed in to change notification settings - Fork 40.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kubectl default container behavior #99833
kubectl default container behavior #99833
Conversation
Hi @mengjiao-liu. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
31cfe9b
to
fe5dd12
Compare
kubectl.kubernetes.io/default-container
On queue for the review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
👍
/ok-to-test |
@mengjiao-liu looks like there is a conflict. Could you please rebase so we can do a fresh review? |
/cc @eddiezane |
722cb94
to
02b5717
Compare
/lgtm |
/lgtm |
Hi @mengjiao-liu, a friendly reminder that the code freeze for 1.21 is today. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
02b5717
to
88e5301
Compare
/retest |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: eddiezane, mengjiao-liu, pacoxu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Adding the PR to the v1.21 milestone, since most of the changes were lgtm'ed prior to Code Freeze and the change here doesn't carry much risk. /milestone v1.21 |
/retest |
What type of PR is this?
/kind feature
What this PR does / why we need it:
specify the default container for
kubectl attach, cp, exec
command with annotationkubectl.kubernetes.io/default-container
The following files are created
staging/src/k8s.io/kubectl/pkg/cmd/util/default-container.go
This avoids duplicate code and help having a single place for maintenance.
more details can be seen in the KEP KEP-2227: default container behavior
Which issue(s) this PR fixes:
Ref enhancements issue
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: