Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix case of Age column in kubectl describe node #96963

Merged
merged 1 commit into from
Mar 9, 2021
Merged

Fix case of Age column in kubectl describe node #96963

merged 1 commit into from
Mar 9, 2021

Conversation

bl-ue
Copy link
Contributor

@bl-ue bl-ue commented Nov 30, 2020 •
edited by liggitt
Loading

What type of PR is this?
/kind bug

What this PR does / why we need it:
Fixes casing of pod age column in the output of kubectl describe node

Which issue(s) this PR fixes:
Fixes #96919

Special notes for your reviewer:
See #63485

Does this PR introduce a user-facing change?:

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Nov 30, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @bl-ue. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/kubectl sig/cli Categorizes an issue or PR as relevant to SIG CLI. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Nov 30, 2020
@bl-ue
Copy link
Contributor Author

bl-ue commented Nov 30, 2020

@derekwaynecarr @mengqiy This change needs to be made in the kubernetes/kubectl repository too—should I have made this PR over there or will it be ported?

@bl-ue
Copy link
Contributor Author

bl-ue commented Dec 1, 2020

/assign @soltysh

@bl-ue
Copy link
Contributor Author

bl-ue commented Dec 2, 2020

/remove-kind cleanup
/kind bug

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. and removed kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Dec 2, 2020
@bl-ue
Copy link
Contributor Author

bl-ue commented Dec 4, 2020

/assign @fedebongio

@derekwaynecarr
Copy link
Member

the change makes sense to me, will defer to sig-cli.

/ok-to-test
/unassign

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 26, 2021
@derekwaynecarr derekwaynecarr removed their request for review January 26, 2021 15:59
@bl-ue
Copy link
Contributor Author

bl-ue commented Jan 26, 2021

/test pull-kubernetes-bazel-test

@dougsland
Copy link
Member

looks trivial but make sense to be consistent with the other fields in the describe.
/triage accept
/lgtm

@k8s-ci-robot
Copy link
Contributor

@dougsland: The label(s) triage/accept cannot be applied, because the repository doesn't have them

In response to this:

looks trivial but make sense to be consistent with the other fields in the describe.
/triage accept
/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 29, 2021
@dougsland
Copy link
Member

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jan 29, 2021
soltysh
soltysh approved these changes Mar 4, 2021
View reviewed changes
Copy link
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 4, 2021
ohbus
ohbus approved these changes Mar 7, 2021
View reviewed changes
Copy link

@ohbus ohbus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot
Copy link
Contributor

@ohbus: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bl-ue, ohbus, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pacoxu
Copy link
Member

pacoxu commented Mar 9, 2021

/test pull-kubernetes-unit
the bot hangs for merge this PR

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@bl-ue
Copy link
Contributor Author

bl-ue commented Mar 9, 2021

/test pull-kubernetes-e2e-kind-ipv6

@k8s-ci-robot k8s-ci-robot merged commit 97e2c84 into kubernetes:master Mar 9, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Mar 9, 2021
@bl-ue bl-ue deleted the 96919-kubectl-describe-node-age-col branch March 9, 2021 16:23
@bl-ue
Copy link
Contributor Author

bl-ue commented Mar 9, 2021

Finally! 😅

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Mar 27, 2021
@wilsonehusin wilsonehusin mentioned this pull request Mar 30, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ohbus ohbus ohbus approved these changes

@soltysh soltysh soltysh approved these changes

@mengqiy mengqiy Awaiting requested review from mengqiy

Assignees

@soltysh soltysh

@dougsland dougsland

@fedebongio fedebongio

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubectl cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. sig/cli Categorizes an issue or PR as relevant to SIG CLI. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.21
Development

Successfully merging this pull request may close these issues.

Inconsistent casing of AGE column in describeNodeResource() in kubectl/describe.go
9 participants
@bl-ue @k8s-ci-robot @derekwaynecarr @dougsland @pacoxu @fejta-bot @soltysh @ohbus @fedebongio