test/e2e/manifest:remove unused function #89678
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/priority backlog |
|
/assign @alejandrox1 |
|
i think we can avoid this refactor, having a common function for the read / parse is not really needed here. |
neolit123
reviewed
Mar 31, 2020
| } | ||
|
|
||
| // RoleFromManifest returns a Role from a manifest stored in fileName in the Namespace indicated by ns. | ||
| func RoleFromManifest(fileName, ns string) (*rbacv1.Role, error) { |
neolit123
reviewed
Mar 31, 2020
| @@ -105,9 +71,8 @@ func StatefulSetFromManifest(fileName, ns string) (*appsv1.StatefulSet, error) { | |||
| return &ss, nil | |||
| } | |||
|
|
|||
| // DaemonSetFromManifest returns a DaemonSet from a manifest stored in fileName in the Namespace indicated by ns. | |||
| func DaemonSetFromManifest(fileName, ns string) (*appsv1.DaemonSet, error) { | |||
neolit123
reviewed
Mar 31, 2020
test/e2e/manifest/manifest.go
Outdated
| } | ||
|
|
||
| json, err := utilyaml.ToJSON(data) | ||
| json, err := parseDataFromManifest(fileName) |
There was a problem hiding this comment.
i think the function should be called readJSONFromManifest
neolit123
reviewed
Mar 31, 2020
| @@ -45,33 +39,10 @@ func PodFromManifest(filename string) (*v1.Pod, error) { | |||
| return &pod, nil | |||
| } | |||
|
|
|||
| // RcFromManifest reads a .json/yaml file and returns the rc in it. | |||
| func RcFromManifest(fileName string) (*v1.ReplicationController, error) { | |||
There was a problem hiding this comment.
Since the commit d8a7025 RcFromManifest() has been unused.
|
/test pull-kubernetes-verify |
|
/test pull-kubernetes-kubemark-e2e-gce-big |
|
/cc @neolit123 |
oomichi
reviewed
Apr 1, 2020
| @@ -45,33 +39,10 @@ func PodFromManifest(filename string) (*v1.Pod, error) { | |||
| return &pod, nil | |||
| } | |||
|
|
|||
| // RcFromManifest reads a .json/yaml file and returns the rc in it. | |||
| func RcFromManifest(fileName string) (*v1.ReplicationController, error) { | |||
There was a problem hiding this comment.
Since the commit d8a7025 RcFromManifest() has been unused.
| @@ -105,9 +71,8 @@ func StatefulSetFromManifest(fileName, ns string) (*appsv1.StatefulSet, error) { | |||
| return &ss, nil | |||
| } | |||
|
|
|||
| // DaemonSetFromManifest returns a DaemonSet from a manifest stored in fileName in the Namespace indicated by ns. | |||
| func DaemonSetFromManifest(fileName, ns string) (*appsv1.DaemonSet, error) { | |||
| } | ||
|
|
||
| // RoleFromManifest returns a Role from a manifest stored in fileName in the Namespace indicated by ns. | ||
| func RoleFromManifest(fileName, ns string) (*rbacv1.Role, error) { |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: oomichi, tanjunchen The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
test/e2e/manifest:remove unused function and extract common function
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: