Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kubeadm upgrades always persist the etcd backup for stacked #86861

Merged
merged 1 commit into from
Jan 17, 2020
Merged

kubeadm upgrades always persist the etcd backup for stacked #86861

merged 1 commit into from
Jan 17, 2020
+18 −65

Conversation

SataQiu
Copy link
Member

@SataQiu SataQiu commented Jan 6, 2020

What type of PR is this?
/kind bug
/kind cleanup

What this PR does / why we need it:
kubeadm upgrades always persist the etcd backup for stacked

Which issue(s) this PR fixes:

Fixes kubernetes/kubeadm#1998

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

kubeadm upgrades always persist the etcd backup for stacked

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/kubeadm sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jan 6, 2020
@SataQiu SataQiu force-pushed the fix-kubeadm-20200106 branch from e252050 to 72559ec Compare January 6, 2020 04:36
@SataQiu
Copy link
Member Author

SataQiu commented Jan 6, 2020

/test pull-kubernetes-e2e-kind
/test pull-kubernetes-e2e-gce-100-performance

@SataQiu
Copy link
Member Author

SataQiu commented Jan 7, 2020

/assign @neolit123

@neolit123
Copy link
Member

ideally i want more comments on kubernetes/kubeadm#1998
we might want to do a backup but not rollback to it in the case of etcd HA.

neolit123
neolit123 reviewed Jan 17, 2020
View reviewed changes
Copy link
Member

@neolit123 neolit123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

i'm proceeding with this change to have the consistency.
it's up to the user if they want to restore from a stacked member or not.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 17, 2020
@neolit123
Copy link
Member

/priority important-longterm

@k8s-ci-robot k8s-ci-robot added priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jan 17, 2020
@neolit123
Copy link
Member

@SataQiu please LGTM, which is the docs update:
kubernetes/website#18424

This was referenced Jan 17, 2020
Merged
Closed
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: neolit123, SataQiu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 17, 2020
@neolit123
Copy link
Member

/remove-kind bug

@k8s-ci-robot k8s-ci-robot removed the kind/bug Categorizes issue or PR as related to a bug. label Jan 17, 2020
@SataQiu
Copy link
Member Author

SataQiu commented Jan 17, 2020

/test pull-kubernetes-kubemark-e2e-gce-big

@k8s-ci-robot k8s-ci-robot merged commit 916edd9 into kubernetes:master Jan 17, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Jan 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neolit123 neolit123 neolit123 left review comments

@rosti rosti Awaiting requested review from rosti

@yagonobre yagonobre Awaiting requested review from yagonobre

Assignees

@neolit123 neolit123

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubeadm cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.18
Development

Successfully merging this pull request may close these issues.

upgrades: make etcd backup consistent for single CP and HA
3 participants
@SataQiu @neolit123 @k8s-ci-robot