Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

partially cleanup hack/jenkins/... #81545

Merged
merged 2 commits into from
Aug 17, 2019
Merged

partially cleanup hack/jenkins/... #81545

merged 2 commits into from
Aug 17, 2019

Conversation

BenTheElder
Copy link
Member

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change
/kind bug

/kind cleanup

/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it: Removes dead / unused scripts, updates the jenkins docs to reflect the current state (as of at least a year ago...)

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

/cc @spiffxp

@k8s-ci-robot k8s-ci-robot requested a review from spiffxp August 17, 2019 06:49
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Aug 17, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 17, 2019
@BenTheElder
Copy link
Member Author

The remaining scripts in this directory still appear to be actively used by CI.

For follow up:

We should consider if we care enough to move this to a hack/ci or similar in the future (maybe move the scripts, add stubs in the old locations, update CI, remove the stubs?) /shrug

We should also consider if we even need the integration and verify scripts versus the make target(s) ...

@BenTheElder
Copy link
Member Author

/sig testing
/priority backlog

@k8s-ci-robot k8s-ci-robot added sig/testing Categorizes an issue or PR as relevant to SIG Testing. priority/backlog Higher priority than priority/awaiting-more-evidence. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Aug 17, 2019
@BenTheElder
Copy link
Member Author

/retest

@spiffxp
Copy link
Member

spiffxp commented Aug 17, 2019

/lgtm
I looked with cs.k8s.io and the most I could find referencing these were out-of-date comments

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 17, 2019
@spiffxp
Copy link
Member

spiffxp commented Aug 17, 2019

We should also consider if we even need the integration and verify scripts versus the make target(s) ...

That's sort of where I'm at after looking at these. They're not referenced in the repo at all. They seem like they should be part of the CI job rather than in this repo, or the CI jobs should be updated to invoke these targets the same way developers would

@k8s-ci-robot k8s-ci-robot merged commit b1274c8 into kubernetes:master Aug 17, 2019
@k8s-ci-robot k8s-ci-robot added this to the v1.16 milestone Aug 17, 2019
@BenTheElder BenTheElder deleted the prow branch August 17, 2019 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spiffxp spiffxp Awaiting requested review from spiffxp

Assignees

@spiffxp spiffxp

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/backlog Higher priority than priority/awaiting-more-evidence. release-note-none Denotes a PR that doesn't merit a release note. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
v1.16
Development

Successfully merging this pull request may close these issues.
3 participants
@BenTheElder @k8s-ci-robot @spiffxp