-
Notifications
You must be signed in to change notification settings - Fork 40.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add note prior to interactive confirm of kubeadm upgrade apply #57116
Conversation
some users may want to do a comparison of the changes between versions but not think to copy off the existing config files prior to running the upgrade addresses kubernetes/kubeadm#489
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: jipperinbham Assign the PR to them by writing Associated issue: #489 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
/ok-to-test |
@jipperinbham: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @jipperinbham!
Thanks for this contribution :)
What is the rationale for adding this information?
This is why we added --dry-run
, don't you think that is enough for this purpose?
(Feel free to disagree with me :P)
@jipperinbham is this because |
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
much better solution was proposed and implemented, #63930 |
What this PR does / why we need it:
informs users when running
kubeadm upgrade apply
in interactive mode to first copy the existing config files in the event they are wanting to diff the changes between versionsWhich issue(s) this PR fixes:
Fixes kubernetes/kubeadm#489
Special notes for your reviewer:
Release note: