Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prepare AllocateLoadBalancerNodePorts for GA #107027

Merged
merged 2 commits into from
Dec 17, 2021
Merged

Prepare AllocateLoadBalancerNodePorts for GA #107027

merged 2 commits into from
Dec 17, 2021

Conversation

uablrek
Copy link
Contributor

@uablrek uablrek commented Dec 14, 2021 •
edited
Loading

What type of PR is this?

Prepares the AllocateLoadBalancerNodePorts feature for GA. Feature-gate: ServiceLBNodePortControl.

/kind cleanup

What this PR does / why we need it:

To allow AllocateLoadBalancerNodePorts to graduate.

Which issue(s) this PR fixes:

N/A

Special notes for your reviewer:

Does this PR introduce a user-facing change?

The `ServiceLBNodePortControl` feature graduates to GA. The feature gate will be removed in 1.26.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 14, 2021
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Dec 14, 2021 •
edited
Loading

CLA Signed

The committers are authorized under a signed CLA.

  • ✅ Lars Ekman (b5b10a93ee847e91dba6bfb047b6213a5d78a8f6, 9202e592c411bd8eedd4222cd1a1f0b8b583d4d1, f2be9841c5cfab2371d8cd9a2245ee8a7c54fa94, b7a7fbdcf2741ab6d952971f36ec06d389e1aa9a)

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Dec 14, 2021
@k8s-ci-robot
Copy link
Contributor

@uablrek: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Dec 14, 2021
@k8s-ci-robot k8s-ci-robot added kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API sig/apps Categorizes an issue or PR as relevant to SIG Apps. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Dec 14, 2021
@uablrek
Copy link
Contributor Author

uablrek commented Dec 14, 2021

/sig network
/remove-sig apps

@k8s-ci-robot k8s-ci-robot added sig/network Categorizes an issue or PR as relevant to SIG Network. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/apps Categorizes an issue or PR as relevant to SIG Apps. and removed sig/apps Categorizes an issue or PR as relevant to SIG Apps. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 14, 2021
@uablrek uablrek mentioned this pull request Dec 14, 2021
Closed
@uablrek uablrek force-pushed the disable-nodeport-ga branch from a7b1b7e to dee1f34 Compare December 14, 2021 17:08
@uablrek uablrek marked this pull request as ready for review December 14, 2021 17:09
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 14, 2021
@uablrek
Copy link
Contributor Author

uablrek commented Dec 14, 2021

There are ServiceLBNodePortControl still comments in 2 files that seem to be generated;

  • staging/src/k8s.io/cli-runtime/artifacts/openapi/swagger.json
  • staging/src/k8s.io/kubectl/testdata/openapi/swagger.json

I have executed hack/update-generated-swagger-docs.sh but these are not updated.

@uablrek
Copy link
Contributor Author

uablrek commented Dec 14, 2021

/cc @andrewsykim

@uablrek
Copy link
Contributor Author

uablrek commented Dec 16, 2021

maybe we should squash some changes?

That was my intention, please see #107027 (comment).

But what about the remaining "swagger.json" files in staging and vendor? Is is ok anyway?

I posted a query on slack #kubernetes-contributors but have no answer so far.

@aojea
Copy link
Member

aojea commented Dec 16, 2021 •
edited
Loading

But what about the remaining "swagger.json" files in staging and vendor? Is is ok anyway?

on generators we trust 😄 , if CI is happy 🤷

let's ask @liggitt

@liggitt
Copy link
Member

liggitt commented Dec 16, 2021 •
edited
Loading

But what about the remaining "swagger.json" files in staging and vendor? Is is ok anyway?

on generators we trust 😄 , if CI is happy 🤷

let's ask @liggitt

I'm not sure what the question is... I think all the swagger.json files under staging are test fixtures snapshotting typical k8s openapi json structure... it's not important they perfectly match current generated openapi

@uablrek
Copy link
Contributor Author

uablrek commented Dec 16, 2021

I made the

grep -lr ServiceLBNodePortControl . | grep -Fv '.git' | grep -Fv _output

to make sure I flushed all references to the ServiceLBNodePortControl feature-gateway except in ./pkg/features/kube_features.go. The "swagger.json" files are under version control. I think I have missed some generation script.

@uablrek uablrek force-pushed the disable-nodeport-ga branch from 4e608e8 to 0ac38a7 Compare December 16, 2021 16:20
@k8s-ci-robot k8s-ci-robot added sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/apps Categorizes an issue or PR as relevant to SIG Apps. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Dec 16, 2021
@uablrek
Copy link
Contributor Author

uablrek commented Dec 16, 2021

Squashed manual updates. A separate commit for generated files.
The old comments are still in the "swagger.json" files as discussed above.

@uablrek
Copy link
Contributor Author

uablrek commented Dec 16, 2021

/remove-sig apps
/remove-sig api-machinery

@k8s-ci-robot k8s-ci-robot removed sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. labels Dec 16, 2021
@uablrek
Copy link
Contributor Author

uablrek commented Dec 16, 2021

Shall it be something in the "Does this PR introduce a user-facing change?" box in this PR?

@aojea
Copy link
Member

aojea commented Dec 16, 2021 •
edited
Loading

Shall it be something in the "Does this PR introduce a user-facing change?" box in this PR?

yeah, add a release note informing the feature move to GA, the template also has something to link the KEP

@aojea
Copy link
Member

aojea commented Dec 16, 2021

/lgtm

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Dec 16, 2021
@sftim
Copy link
Contributor

sftim commented Dec 16, 2021

changelog entry nit:

-The `ServiceLBNodePortControl` graduates to GA. The feature-gate will be removed in 1.26.
+The `ServiceLBNodePortControl` feature graduates to GA. The feature gate will be removed in 1.26.

thockin
thockin reviewed Dec 17, 2021
View reviewed changes
Copy link
Member

@thockin thockin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: thockin, uablrek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 17, 2021
@k8s-ci-robot k8s-ci-robot merged commit a1e8a5b into kubernetes:master Dec 17, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.24 milestone Dec 17, 2021
This was referenced Jan 21, 2022
Merged
Merged
@tengqm tengqm mentioned this pull request Mar 18, 2022
Merged
@uablrek uablrek deleted the disable-nodeport-ga branch April 29, 2023 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewsykim andrewsykim andrewsykim left review comments

@aojea aojea aojea left review comments

@thockin thockin thockin left review comments

@justinsb justinsb Awaiting requested review from justinsb

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

Assignees

@thockin thockin

@aojea aojea

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/network Categorizes an issue or PR as relevant to SIG Network. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.24
Development

Successfully merging this pull request may close these issues.
9 participants
@uablrek @k8s-ci-robot @k8s-triage-robot @roycaihw @aojea @liggitt @sftim @thockin @andrewsykim