Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[go1.17] Update to go1.17.5 #106956

Merged
merged 1 commit into from
Dec 10, 2021
Merged

[go1.17] Update to go1.17.5 #106956

merged 1 commit into from
Dec 10, 2021
+10 −10

Conversation

cpanato
Copy link
Member

@cpanato cpanato commented Dec 10, 2021

What type of PR is this?

/kind feature
/area dependency release-eng release-eng/security security

What this PR does / why we need it:

Update Kubernetes to go1.17.5

Tracking issue: kubernetes/release#2349

/assign @dims @liggitt @justaugustus
cc: @kubernetes/release-engineering

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Kubernetes is now built with Golang 1.17.5

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@cpanato
[go1.17] Update to go1.17.5
4bda969 
Signed-off-by: Carlos Panato <ctadeu@gmail.com>
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. labels Dec 10, 2021
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. area/dependency Issues or PRs related to dependency changes area/release-eng Issues or PRs related to the Release Engineering subproject area/security cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Dec 10, 2021
@k8s-ci-robot
Copy link
Contributor

@cpanato: The label(s) area/release-eng/security cannot be applied, because the repository doesn't have them.

In response to this:

What type of PR is this?

/kind feature
/area dependency release-eng release-eng/security security

What this PR does / why we need it:

Update Kubernetes to go1.17.5

Tracking issue: kubernetes/release#2349

/assign @dims @liggitt @justaugustus
cc: @kubernetes/release-engineering

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Kubernetes is now built with Golang 1.17.5

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/provider/gcp Issues or PRs related to gcp provider labels Dec 10, 2021
@k8s-ci-robot k8s-ci-robot requested a review from jpbetz December 10, 2021 15:59
@k8s-ci-robot k8s-ci-robot added sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Dec 10, 2021
@cpanato cpanato mentioned this pull request Dec 10, 2021
Closed
27 tasks
mkumatag
mkumatag approved these changes Dec 10, 2021
View reviewed changes
Copy link
Member

@mkumatag mkumatag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 10, 2021
@dims
Copy link
Member

dims commented Dec 10, 2021

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, dims, mkumatag

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 10, 2021
@k8s-ci-robot k8s-ci-robot merged commit 4ea2448 into kubernetes:master Dec 10, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.24 milestone Dec 10, 2021
This was referenced Dec 12, 2021
Merged
Merged
@roycaihw
Copy link
Member

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Dec 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkumatag mkumatag mkumatag approved these changes

@jpbetz jpbetz Awaiting requested review from jpbetz

Assignees

@dims dims

@justaugustus justaugustus

@liggitt liggitt

@mkumatag mkumatag

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/dependency Issues or PRs related to dependency changes area/provider/gcp Issues or PRs related to gcp provider area/release-eng Issues or PRs related to the Release Engineering subproject area/security area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.24
Development

Successfully merging this pull request may close these issues.
7 participants
@cpanato @k8s-ci-robot @dims @roycaihw @mkumatag @justaugustus @liggitt