-
Notifications
You must be signed in to change notification settings - Fork 40.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to runc v 1.0.3 #106912
Update to runc v 1.0.3 #106912
Conversation
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Welcome @Letme! |
Hi @Letme. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/check-cla |
/sig node |
You should run To pin dependency version, you should try something like below.
|
I did a quick example like https://github.com/kubernetes/kubernetes/compare/master...pacoxu:runc-v1.0.3?expand=1 that you can follow. |
Thanks for the commands - I indeed did it by hand initially. So now with your commands I have cb7ff96e08c and I also ran the lint-dependencies as suggested and that also passed. |
/priority important-longterm |
/ping on this... I would love to get it into update, so that I can get more nodes running. |
@SergeyKanzhelev did you get a chance to peek? |
Reviewed the release notes, looks good for master. I'm not sure about the cherry-picks though. /lgtm |
@Letme do you know what version the issue was introduced in? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
@SergeyKanzhelev no, but I tested on all currently supported versions (v1.21.4 1.21.7 1.22.4 and 1.23.0) and it was there in all. So I would expect this to get cherry-picked for those versions. |
/approve /hold for @mrunalp ack if desired I'm also unsure about the picks, especially to <= 1.21, since that was still on pre-1.0 runc RCs |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kolyshkin, Letme, liggitt The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
/hold cancel |
The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass. This bot retests PRs for certain kubernetes repos according to the following rules:
You can:
/retest |
/skip |
/retest |
@Letme: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/test pull-kubernetes-integration |
I am a bit puzzled why this was not added to recent 1.23.2 release. Can someone explain? It would fix and existing bug in all the currently supported versions on RaspberryPi's |
/milestone v1.22 |
@Letme: You must be a member of the kubernetes/milestone-maintainers GitHub team to set the milestone. If you believe you should be able to issue the /milestone command, please contact your and have them propose you as an additional delegate for this responsibility. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What type of PR is this?
/kind bug
/kind regression
What this PR does / why we need it:
Current version (1.0.2) of runc prevents Kubernetes from running on RaspberryPi4 with non-hugetlb compiled kernel (standard Raspbian Bullseye). There is a fix inside Runc 1.0.3 for
libct/cg/fs2: fix GetStats for unsupported hugetlb
(opencontainers/runc#3233), which needs to be delivered to all existing supported Kubernetes versions (I tested v1.21.4 1.21.7 1.22.4 and 1.23.0).Which issue(s) this PR fixes:
Fixes #
opencontainers/runc#3232
Special notes for your reviewer:
My first contribution, so I am not sure it is this simple.
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: