Update configure-helper.sh #104135
Update configure-helper.sh #104135
Conversation
add live-restore true by default.
| @@ -1506,12 +1506,6 @@ function set_docker_options_non_ubuntu() { | |||
|
|
|||
| addockeropt "\"mtu\": 1460," | |||
There was a problem hiding this comment.
these should also be moved a level up then? Since the config file is overrriden, it doesn't matter what were the default any longer
There was a problem hiding this comment.
live-restore and storage-driver is already as an input in the ubuntu preloading image. Adding these to daemon.json might result in failure.
|
/sig cloud-provider |
|
/release-note-none |
|
/retest |
| echo "setting live restore" | ||
| # Disable live-restore if the environment variable is set. | ||
| if [[ "${DISABLE_DOCKER_LIVE_RESTORE:-false}" == "true" ]]; then | ||
| addockeropt "\"live-restore\": \"false\"," | ||
| addockeropt "\"live-restore\": false," |
There was a problem hiding this comment.
are quotes removed intentionally?
There was a problem hiding this comment.
checked, likely not-quoted version works better
There was a problem hiding this comment.
yes, setting the string for boolean values is not working properly.
|
/lgtm marking as a bug as when this is missing, the behavior on docker restart is very disruptive. It is a degradation from the logic we had before switching to using docker config instead of command line options |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dchen1107, vteratipally The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…-of-#104135-upstream-release-1.20 Automated cherry pick of #104135: Update configure-helper.sh
…-of-#104135-upstream-release-1.21 Automated cherry pick of #104135: Update configure-helper.sh
…-of-#104135-upstream-release-1.22 Automated cherry pick of #104135: Update configure-helper.sh
add live-restore true by default.
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: