Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update golang.org/x/net #103176

Merged
merged 1 commit into from
Jul 1, 2021
Merged

Update golang.org/x/net #103176

merged 1 commit into from
Jul 1, 2021

Conversation

CaoDonghui123
Copy link
Contributor

@CaoDonghui123 CaoDonghui123 commented Jun 25, 2021 •
edited
Loading

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Update golang.org/x/net to v0.0.0-20210520170846-37e1c6afe023

1 .hack/pin-dependency.sh golang.org/x/net v0.0.0-20210520170846-37e1c6afe023
2. hack/update-vendor.sh
3. hack/update-internal-modules.sh

Which issue(s) this PR fixes:

Fixes #103166

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Update golang.org/x/net to v0.0.0-20210520170846-37e1c6afe023

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jun 25, 2021
@k8s-ci-robot k8s-ci-robot requested review from brendandburns, cheftako and a team June 25, 2021 07:32
@k8s-ci-robot k8s-ci-robot added area/apiserver area/cloudprovider area/code-generation area/dependency Issues or PRs related to dependency changes area/kubectl sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/storage Categorizes an issue or PR as relevant to SIG Storage. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jun 25, 2021
BenTheElder
BenTheElder reviewed Jun 25, 2021
View reviewed changes
Copy link
Member

@BenTheElder BenTheElder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

initial pass, vendor looks fine.

i'm not sure if kubernetes uses the affected API anywhere (maybe in the doc generation?)

vendor/golang.org/x/net/http2/write.go
if !ascii {
// Skip writing invalid headers. Per RFC 7540, Section 8.1.2, header
// field names have to be ASCII characters (just as in HTTP/1.x).
continue
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this seems potentially notable.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

validWireHeaderFieldName below already skipped outputting strings which contained non-ascii characters ... this addition is catching things that were not ascii, but got transformed to ascii by strings.ToLower ... given they didn't work in http/1.x, and were being transformed to non-round-trippable lowercase headers, I'm not especially concerned about this

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm just not sure where all this is used, and it appears to be technically a breaking change, HTTP clients etc. seem notorious for doing / depending on out-of-spec stuff like this.

vendor/golang.org/x/net/http2/headermap.go
}
return strings.ToLower(v)
return asciiToLower(v)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also possibly notable

@wzshiming
Copy link
Member

I think that non-ASCII characters should not appear in the header.

/lgtm

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jun 25, 2021
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 29, 2021
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@fedebongio
Copy link
Contributor

/remove-sig api-machinery

@k8s-ci-robot k8s-ci-robot removed the sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. label Jun 29, 2021
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@BenTheElder
Copy link
Member

/hold
https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/103176/pull-kubernetes-dependencies/1409997425136898048

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 29, 2021
@k8s-ci-robot k8s-ci-robot added sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/auth Categorizes an issue or PR as relevant to SIG Auth. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Jun 30, 2021
@CaoDonghui123
Copy link
Contributor Author

Let me rebase this PR

@CaoDonghui123
Copy link
Contributor Author

@BenTheElder I fix it

@logicalhan
Copy link
Member

/remove-sig instrumentation

@k8s-ci-robot k8s-ci-robot removed the sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. label Jun 30, 2021
@BenTheElder
Copy link
Member

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 30, 2021
@CaoDonghui123
Copy link
Contributor Author

need LGTM...

@liggitt
Copy link
Member

liggitt commented Jul 1, 2021

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 1, 2021
@k8s-ci-robot k8s-ci-robot merged commit c14017b into kubernetes:master Jul 1, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.22 milestone Jul 1, 2021
@CaoDonghui123 CaoDonghui123 deleted the updatemod branch July 1, 2021 05:34
@fedebongio
Copy link
Contributor

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jul 1, 2021
This was referenced Jul 14, 2021
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liggitt liggitt liggitt left review comments

@BenTheElder BenTheElder BenTheElder left review comments

@brendandburns brendandburns Awaiting requested review from brendandburns

@cheftako cheftako Awaiting requested review from cheftako

Assignees

@liggitt liggitt

@wzshiming wzshiming

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver area/cloudprovider area/code-generation area/dependency Issues or PRs related to dependency changes area/kubectl cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG Node: code and documentation PRs
Archived in project
Milestone
v1.22
Development

Successfully merging this pull request may close these issues.

CVE-2021-33194: Update golang.org/x/net to v0.0.0-20210520170846-37e1c6afe023
8 participants
@CaoDonghui123 @wzshiming @liggitt @k8s-ci-robot @fejta-bot @fedebongio @BenTheElder @logicalhan