Azure: avoid setting cached Sku when updating VMSS and VMSS instances #102005
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/priority important-soon |
|
/retest |
1 similar comment
|
/retest |
|
@chewong could you help to check why those aks-engine tests are failing? |
|
/retest |
|
@cheftako kindly ping to approve |
This was referenced May 19, 2021
Will do but can I get you or @andyzhangx or @ritazh to lgtm? |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andyzhangx, cheftako, feiskyer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added a commit
that referenced
this pull request
Jun 8, 2021
…2005-upstream-release-1.19 Automated cherry pick of #102005: Azure: avoid setting cached Sku when updating VMSS and VMSS
k8s-ci-robot
added a commit
that referenced
this pull request
Jun 8, 2021
…2005-upstream-release-1.21 Automated cherry pick of #102005: Azure: avoid setting cached Sku when updating VMSS and VMSS
k8s-ci-robot
added a commit
that referenced
this pull request
Jun 8, 2021
…2005-upstream-release-1.20 Automated cherry pick of #102005: Azure: avoid setting cached Sku when updating VMSS and VMSS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
/sig cloud-provider
/area provider/azure
What this PR does / why we need it:
Cherry-pick of fixes from out-of-tree kubernetes-sigs/cloud-provider-azure#630:
Since the VMSS and instances are cached in memory (default TTL is 10 min), if there're some changes on the VMSS capacity (e.g. by autoscaler), then the capacity value would be outdated in memory. However, cloud provider sets vmss.Sku when updating network profile, which may cause unexpected capacity change on VMSS.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: