Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update glbc image to v1.12.0 #101772

Merged
merged 1 commit into from
May 7, 2021
Merged

Update glbc image to v1.12.0 #101772

merged 1 commit into from
May 7, 2021

Conversation

swetharepakula
Copy link
Member

@swetharepakula swetharepakula commented May 6, 2021 •
edited
Loading

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

This PR updates the GLBC image so that networking.k8s.io/v1beta1 APIs are not longer required. This is necessary for E2E tests to pass once v1beta1 Ingress is removed.

Which issue(s) this PR fixes:

fixes #100560
Unblocks #99840

Does this PR introduce a user-facing change?

NONE

/sig-network
/cc @aojea @robscott @prameshj
/assign @liggitt @freehan

@swetharepakula
Update glbc image to v1.12.0
8c8db0d 
 - glbc now uses networking.k8s.io/v1 Ingress
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels May 6, 2021
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels May 6, 2021
@k8s-ci-robot
Copy link
Contributor

@swetharepakula: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels May 6, 2021
@swetharepakula
Copy link
Member Author

/sig network

@k8s-ci-robot k8s-ci-robot added sig/network Categorizes an issue or PR as relevant to SIG Network. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels May 6, 2021
@freehan
Copy link
Contributor

freehan commented May 6, 2021

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 6, 2021
@liggitt
Copy link
Member

liggitt commented May 6, 2021

cc @deads2k

@deads2k
Copy link
Contributor

deads2k commented May 6, 2021

Very glad to see this. Thanks.

@k8s-ci-robot k8s-ci-robot added area/provider/gcp Issues or PRs related to gcp provider sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. labels May 6, 2021
@swetharepakula swetharepakula mentioned this pull request May 6, 2021
Merged
@swetharepakula
Copy link
Member Author

fixes #100560

@swetharepakula swetharepakula mentioned this pull request May 6, 2021
Closed
@liggitt
Copy link
Member

liggitt commented May 7, 2021

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: freehan, liggitt, swetharepakula

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 7, 2021
@k8s-ci-robot k8s-ci-robot merged commit 8b1c82a into kubernetes:master May 7, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.22 milestone May 7, 2021
@wojtek-t
Copy link
Member

wojtek-t commented May 7, 2021

Great!

@swetharepakula swetharepakula deleted the bump-glbc-image branch May 7, 2021 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aojea aojea Awaiting requested review from aojea

@prameshj prameshj Awaiting requested review from prameshj

@robscott robscott Awaiting requested review from robscott

Assignees

@liggitt liggitt

@freehan freehan

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/gcp Issues or PRs related to gcp provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/network Categorizes an issue or PR as relevant to SIG Network. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.22
Development

Successfully merging this pull request may close these issues.

Pick up l7-lb-controller version that uses v1 APIs
6 participants
@swetharepakula @k8s-ci-robot @freehan @liggitt @deads2k @wojtek-t