Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

conformance test for Services should validate behaviour #101709

Merged
merged 1 commit into from
May 6, 2021
Merged

conformance test for Services should validate behaviour #101709

merged 1 commit into from
May 6, 2021

Conversation

aojea
Copy link
Member

@aojea aojea commented May 3, 2021 •
edited
Loading

Current test for service with endpoints only validate the API objects,
however, doesn't validate that the implementation of Services works.

This mean that a cluster without any component implementing Services,
can pass Conformance.

/kind bug

Fixes: #101446

The conformance tests:
- Services should serve multiport endpoints from pods
- Services should serve a basic endpoint from pods
were only validating the API objects, not performing any validation on the actual Services implementation.
Those tests now validate that the Services under test are able to forward traffic to the endpoints.

@aojea
conformance test for Services should validate behavior
2dc4dba 
Current test for service with endpoints only validate the API objects,
however, doesn't validate that the implementation of Services works.

This mean that a cluster without any component implementing Services,
can pass Conformance.
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels May 3, 2021
@k8s-ci-robot
Copy link
Contributor

@aojea: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label May 3, 2021
@aojea
Copy link
Member Author

aojea commented May 3, 2021

/assign @johnbelamaric @spiffxp
/cc @thockin @dcbw

@k8s-ci-robot k8s-ci-robot requested review from dcbw and thockin May 3, 2021 15:34
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aojea

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test sig/network Categorizes an issue or PR as relevant to SIG Network. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels May 3, 2021
@aojea
Copy link
Member Author

aojea commented May 3, 2021

/retest
[sig-node] Probing container should be ready immediately after startupProbe succeeds expand_more

@JornShen
Copy link
Member

JornShen commented May 6, 2021

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 6, 2021
@k8s-ci-robot k8s-ci-robot merged commit 413ac5d into kubernetes:master May 6, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.22 milestone May 6, 2021
@github-actions github-actions bot mentioned this pull request May 11, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcbw dcbw Awaiting requested review from dcbw

@thockin thockin Awaiting requested review from thockin

@caseydavenport caseydavenport Awaiting requested review from caseydavenport

@rramkumar1 rramkumar1 Awaiting requested review from rramkumar1

Assignees

@spiffxp spiffxp

@johnbelamaric johnbelamaric

@JornShen JornShen

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/network Categorizes an issue or PR as relevant to SIG Network. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.22
Development

Successfully merging this pull request may close these issues.

The e2e conformance tests "should serve multiport endpoints from pods" doesn't check connectivity
5 participants
@aojea @k8s-ci-robot @JornShen @spiffxp @johnbelamaric