Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

azure storage account num exhausting issue #54669

Closed
andyzhangx opened this issue Oct 27, 2017 · 1 comment · Fixed by #54459
Closed

azure storage account num exhausting issue #54669

andyzhangx opened this issue Oct 27, 2017 · 1 comment · Fixed by #54459
Assignees
@andyzhangx
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@andyzhangx
Copy link
Member

Is this a BUG REPORT or FEATURE REQUEST?:
/kind bug

Uncomment only one, leave it on its own line:

/kind bug
/kind feature

What happened:
If customer is using the default storage class of azure-disk, create lots of azure disk pvs by using default storage class of azure-disk, the storage account num would be exhausted in the azure subscription. Change default kind value of azure disk storge class from Dedicated to Shared, which means only a few storage accounts would be created even there are even hundreds of azure disk PVs.
What you expected to happen:

How to reproduce it (as minimally and precisely as possible):

Anything else we need to know?:

Environment:

  • Kubernetes version (use kubectl version):
  • Cloud provider or hardware configuration:
  • OS (e.g. from /etc/os-release):
  • Kernel (e.g. uname -a):
  • Install tools:
  • Others:

/sig azure
@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. sig/azure labels Oct 27, 2017
@andyzhangx
Copy link
Member Author

/assign andyzhangx

@andyzhangx andyzhangx mentioned this issue Oct 27, 2017
Merged
vdemeester pushed a commit to vdemeester/kubernetes that referenced this issue Oct 27, 2017
Merge pull request kubernetes#54459 from andyzhangx/azure-change-defa…
d85fd8b 
…ult-pv-kind

Automatic merge from submit-queue (batch tested with PRs 53730, 51608, 54459, 54534, 54585). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

fix azure storage account num exhausting issue

**What this PR does / why we need it**:
If customer is using the default storage class of azure-disk, create lots of azure disk pvs by using default storage class of azure-disk, the storage account num would be exhausted in the azure subscription. Change default `kind` value of azure disk storge class from `Dedicated` to `Shared`, which means only a few storage accounts would be created even there are even hundreds of azure disk PVs.

**Which issue this PR fixes**:
fixes kubernetes#54669
fix storage account num exhausting issue when lots of azure disk pvs are created by using the default storage class of azure-disk

**Special notes for your reviewer**:
fix azure storage account num exhausting issue when lots of azure disk pvs are created by using the default storage class of azure-disk
I would suggest also cherry pick this fix to v1.7, v1.8

**Release note**:

```
fix azure storage account num exhausting issue
```

/sig azure
@karataliu @rootfs @brendanburns
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andyzhangx andyzhangx

Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix azure storage account num exhausting issue andyzhangx/kubernetes
2 participants
@andyzhangx @k8s-ci-robot