Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove usage of PersistentVolumeLabel in phases/controlplane/manifests*.go #866

Closed
neolit123 opened this issue May 29, 2018 · 2 comments · Fixed by kubernetes/kubernetes#65827
Closed

Remove usage of PersistentVolumeLabel in phases/controlplane/manifests*.go #866

neolit123 opened this issue May 29, 2018 · 2 comments · Fixed by kubernetes/kubernetes#65827
Assignees
@neolit123 @xlgao-zju
Labels
area/UX kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.
Milestone
v1.12

Comments

@neolit123
Copy link
Member

This PR added usage of --disable-admission-plugins=PersistentVolumeLabel as an APIServer argument:
kubernetes/kubernetes#64165
https://github.com/kubernetes/kubernetes/pull/64165/files#diff-366b1adfb12059a0ddf31d524e8827cbR145
it was done because we need to support 1.10 and because --admission-control is deprecated.

TODO (do this on a later stage in 1.11, not now)
remove PersistentVolumeLabel as it's will be automatically disabled in v1.11:

references:
kubernetes/kubernetes#64326
kubernetes/kubernetes#52618
kubernetes/kubernetes#52617
@neolit123 neolit123 added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. area/UX labels May 29, 2018
@neolit123 neolit123 self-assigned this May 29, 2018
@luxas luxas added this to the v1.12 milestone May 29, 2018
@xlgao-zju
Copy link

/assign
@neolit123 I'd like to help this.

@neolit123
Copy link
Member Author

sounds good!
thank you @xlgao-zju

@xlgao-zju xlgao-zju mentioned this issue Jul 4, 2018
Merged
k8s-github-robot pushed a commit to kubernetes/kubernetes that referenced this issue Jul 5, 2018
Merge pull request #65827 from xlgao-zju/rm-PersistentVolumeLabel
7d12718 
Automatic merge from submit-queue (batch tested with PRs 64593, 65117, 65629, 65827, 65686). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

[kubeadm] Remove usage of `PersistentVolumeLabel` in phases/controlplane/manifests*.go

**What this PR does / why we need it**:
Remove usage of `PersistentVolumeLabel` in phases/controlplane/manifests*.go

**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
Close [kubernetes/kubeadm#866](kubernetes/kubeadm#866)

**Special notes for your reviewer**:
/assign @neolit123 

**Release note**:

```release-note
kubeadm: Remove usage of `PersistentVolumeLabel`
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@neolit123 neolit123

@xlgao-zju xlgao-zju

Labels
area/UX kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.
Projects
None yet
Milestone
v1.12
3 participants
@neolit123 @xlgao-zju @luxas