Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(service): add kube_service_ports metric #2607

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

nahuel11500
Copy link

What this PR does / why we need it:
Adds a simple metric kube_service_ports so that we can get details about the ports exposed by services.
How does this change affect the cardinality of KSM: (increases, decreases or does not change cardinality)
increases

Copy link

linux-foundation-easycla bot commented Feb 9, 2025

CLA Signed

The committers listed above are authorized under a signed CLA.

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Feb 9, 2025
@k8s-ci-robot k8s-ci-robot requested review from mrueg and rexagod February 9, 2025 14:39
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 9, 2025
Signed-off-by: nahuel11500 <134035119+nahuel11500@users.noreply.github.com>
@nahuel11500 nahuel11500 force-pushed the feat/add-kube-service-adress-metric branch from a793b16 to 37e3690 Compare February 9, 2025 14:50
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Feb 9, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: maxime1907, nahuel11500
Once this PR has been reviewed and has the lgtm label, please assign rexagod for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nahuel11500
Copy link
Author

Hello, any thought on this ? @mrueg @dgrisonnet

Thank you

@richabanker
Copy link
Contributor

/triage accepted
/assign @dgrisonnet

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Feb 20, 2025
@nahuel11500
Copy link
Author

Hello, sorry to bother, any update on this ? @dgrisonnet

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants