Skip to content

Commit

Permalink
Makefile,internal/collector: Rename collector -> store
Browse files Browse the repository at this point in the history
Since the removal of collector, this introduces both the concept of the
store and the resources instead of collectors that the user passes in.

The user facing logs and flags were not changed as that would be a
regression.
  • Loading branch information
lilic committed Jun 11, 2019
1 parent 13d2747 commit 68aea02
Show file tree
Hide file tree
Showing 56 changed files with 368 additions and 397 deletions.
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ doccheck: generate
@git diff --exit-code
@echo "- Checking if the documentation is in sync with the code..."
@grep -hoE '(kube_[^ |]+)' docs/* --exclude=README.md| sort -u > documented_metrics
@sed -n 's/.*# TYPE \(kube_[^ ]\+\).*/\1/p' internal/collector/*_test.go | sort -u > tested_metrics
@sed -n 's/.*# TYPE \(kube_[^ ]\+\).*/\1/p' internal/store/*_test.go | sort -u > tested_metrics
@diff -u0 tested_metrics documented_metrics || (echo "ERROR: Metrics with - are present in tests but missing in documentation, metrics with + are documented but not tested."; exit 1)
@echo OK
@rm -f tested_metrics documented_metrics
Expand Down
293 changes: 0 additions & 293 deletions internal/collector/builder.go

This file was deleted.

Loading

0 comments on commit 68aea02

Please sign in to comment.