Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for AL2023 AMI to use Amazon VPC CNI #16350

Merged
merged 1 commit into from
Feb 13, 2024
Merged

Add support for AL2023 AMI to use Amazon VPC CNI #16350

merged 1 commit into from
Feb 13, 2024

Conversation

dims
Copy link
Member

@dims dims commented Feb 11, 2024

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 11, 2024
@dims
Copy link
Member Author

dims commented Feb 11, 2024

/assign @hakman @zetaab

@dims
Copy link
Member Author

dims commented Feb 11, 2024

/assign @olemarkus

@olemarkus
Copy link
Member

Thanks. Will have a look shortly

@dims dims mentioned this pull request Feb 11, 2024
Merged
@dims
Copy link
Member Author

dims commented Feb 11, 2024

/test pull-kops-e2e-k8s-aws-amazonvpc

1 similar comment
@dims
Copy link
Member Author

dims commented Feb 11, 2024

/test pull-kops-e2e-k8s-aws-amazonvpc

@kubernetes kubernetes deleted a comment from k8s-ci-robot Feb 11, 2024
@dims dims force-pushed the add-support-for-al2023-amis-to-use-amazon-vpc-cni branch from 32ee784 to 1330a08 Compare February 12, 2024 01:47
@dims
Copy link
Member Author

dims commented Feb 12, 2024

/test pull-kops-e2e-k8s-aws-amazonvpc

@dims dims changed the title Add support for AL2023 AMI to use Amazon VPC CNI [WIP] Add support for AL2023 AMI to use Amazon VPC CNI Feb 12, 2024
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 12, 2024
@dims dims force-pushed the add-support-for-al2023-amis-to-use-amazon-vpc-cni branch from 1330a08 to 9d7d65f Compare February 12, 2024 03:16
@dims
Copy link
Member Author

dims commented Feb 12, 2024

/test pull-kops-e2e-k8s-aws-amazonvpc

@dims dims force-pushed the add-support-for-al2023-amis-to-use-amazon-vpc-cni branch from 9d7d65f to f7ed08f Compare February 12, 2024 13:26
@dims
Copy link
Member Author

dims commented Feb 12, 2024

/test pull-kops-e2e-k8s-aws-amazonvpc

@dims dims force-pushed the add-support-for-al2023-amis-to-use-amazon-vpc-cni branch from f7ed08f to b605273 Compare February 12, 2024 19:03
@dims
Copy link
Member Author

dims commented Feb 12, 2024

/test pull-kops-e2e-k8s-aws-amazonvpc

@dims dims force-pushed the add-support-for-al2023-amis-to-use-amazon-vpc-cni branch from b605273 to 891d87b Compare February 12, 2024 20:35
@dims
Copy link
Member Author

dims commented Feb 12, 2024

/test pull-kops-e2e-k8s-aws-amazonvpc

1 similar comment
@dims
Copy link
Member Author

dims commented Feb 12, 2024

/test pull-kops-e2e-k8s-aws-amazonvpc

@dims
Copy link
Member Author

dims commented Feb 13, 2024

/test pull-kops-e2e-k8s-aws-amazonvpc

@dims dims force-pushed the add-support-for-al2023-amis-to-use-amazon-vpc-cni branch from 9f455ec to 891d87b Compare February 13, 2024 04:13
@dims
Add support for AL2023 AMI to use Amazon VPC CNI
2940819 
Signed-off-by: Davanum Srinivas <davanum@gmail.com>
@dims dims force-pushed the add-support-for-al2023-amis-to-use-amazon-vpc-cni branch from 891d87b to 2940819 Compare February 13, 2024 04:13
@dims
Copy link
Member Author

dims commented Feb 13, 2024

/test pull-kops-e2e-k8s-aws-amazonvpc

@k8s-ci-robot
Copy link
Contributor

@dims: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kops-e2e-k8s-aws-amazonvpc 2940819 link false /test pull-kops-e2e-k8s-aws-amazonvpc

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@dims dims changed the title [WIP] Add support for AL2023 AMI to use Amazon VPC CNI Add support for AL2023 AMI to use Amazon VPC CNI Feb 13, 2024
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 13, 2024
@dims
Copy link
Member Author

dims commented Feb 13, 2024

/test pull-kops-e2e-k8s-aws-amazonvpc

zetaab
zetaab approved these changes Feb 13, 2024
View reviewed changes
Copy link
Member

@zetaab zetaab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 13, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zetaab

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 13, 2024
@zetaab
Copy link
Member

zetaab commented Feb 13, 2024

/hold

@dims should https://github.com/awslabs/amazon-eks-ami/blob/976fe67e4c359737be71d892a8f55015cc1475f5/scripts/install-worker.sh#L104 be part of this PR?

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 13, 2024
@k8s-ci-robot k8s-ci-robot merged commit b8603a2 into kubernetes:master Feb 13, 2024
21 of 22 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.29 milestone Feb 13, 2024
@zetaab
Copy link
Member

zetaab commented Feb 13, 2024 •
edited
Loading

blah hold did not work :) if that change needs to be part of PR, then we need new PR

@dims
Copy link
Member Author

dims commented Feb 13, 2024

@zetaab already accounted for, see https://github.com/kubernetes/kops/pull/16350/files#diff-7584ff712f1141107b40b89d7a427be0c9505ef9768957c756e3191f5b5e238cR79

@BrewTestBot BrewTestBot mentioned this pull request May 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olemarkus olemarkus olemarkus left review comments

@zetaab zetaab zetaab approved these changes

Assignees

@olemarkus olemarkus

@hakman hakman

@zetaab zetaab

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/nodeup cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.29
Development

Successfully merging this pull request may close these issues.
5 participants
@dims @olemarkus @k8s-ci-robot @zetaab @hakman