-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set KUBECONFIG for LBC's ginkgo tests #16334
Conversation
@@ -33,6 +33,9 @@ ZONES="eu-west-1a,eu-west-1b,eu-west-1c" | |||
|
|||
kops-up | |||
|
|||
export KUBECONFIG=$(mktemp -t kops.XXXXXXXXX) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://www.shellcheck.net/wiki/SC2155
export KUBECONFIG=$(mktemp -t kops.XXXXXXXXX) | |
KUBECONFIG=$(mktemp -t kops.XXXXXXXXX) | |
export KUBECONFIG |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to export?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe so because the ginkgo process is what is loading the client-go config and reading from the KUBECONFIG env var, not just a shell variable.
0741918
to
b73a2dd
Compare
/retest |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hakman The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hoping to fix these tests: https://prow.k8s.io/view/gs/kubernetes-jenkins/logs/e2e-kops-aws-aws-load-balancer-controller/1755828286962798592
The test failures seem to be using the wrong kubeconfig settings, potentially using the "in cluster" config of the prow job pod itself.
This explicitly sets KUBECONFIG so that the ginkgo tests will use the kops cluster's admin credentials
ref: https://kubernetes.slack.com/archives/C8MKE2G5P/p1707502477184889?thread_ts=1707242089.155659&cid=C8MKE2G5P