Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(networking): bump aws cni to 1.16.2 #16297

Merged
merged 2 commits into from
Jan 30, 2024

Conversation

moshevayner
Copy link
Member

What this PR does / why we need it:
Update AWS CNI Version to latest release (v1.16.2)

Special notes for your reviewer:
Release page: https://github.com/aws/amazon-vpc-cni-k8s/releases/tag/v1.16.2

/cc @hakman

@k8s-ci-robot k8s-ci-robot requested a review from hakman January 30, 2024 04:01
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. area/addons labels Jan 30, 2024
@moshevayner
Copy link
Member Author

Hey @hakman!
Following our chat on the previous PR (#16191) - I've been able to spin up a cluster on my personal AWS account using a binary built from my branch, and it successfully validated (see output below).
One caveat is that I had to specifically use a focal image, because with jammy I still hit the same issue from #16255 . I'll get to work on a fix as soon as possible, so that jammy will also work out of the box.
Let me know what you think.
Thanks!

Commands ran locally (with fast-forwarded output):

➜  kops git:(aws-cni-1.16.2) make kops
➜  kops git:(aws-cni-1.16.2) .build/dist/darwin/arm64/kops create cluster --name "cluster.kops-test.vayner.me" --zones us-east-1a --networking amazonvpc --image 099720109477/ubuntu/images/hvm-ssd/ubuntu-focal-20.04-amd64-server-20240126
.
.
.
➜  kops git:(aws-cni-1.16.2) .build/dist/darwin/arm64/kops update cluster --name cluster.kops-test.vayner.me -y 
.
.
.
➜  kops git:(aws-cni-1.16.2) .build/dist/darwin/arm64/kops export kubecfg --admin --name cluster.kops-test.vayner.me                                                                                                          
kOps has set your kubectl context to cluster.kops-test.vayner.me
➜  kops git:(aws-cni-1.16.2) .build/dist/darwin/arm64/kops validate cluster --wait 10m
Using cluster from kubectl context: cluster.kops-test.vayner.me

Validating cluster cluster.kops-test.vayner.me

INSTANCE GROUPS
NAME                            ROLE            MACHINETYPE     MIN     MAX     SUBNETS
control-plane-us-east-1a        ControlPlane    t3.medium       1       1       us-east-1a
nodes-us-east-1a                Node            t3.medium       1       1       us-east-1a

NODE STATUS
NAME                    ROLE            READY
i-050537a81cc545dca     node            True
i-05f719733b1b6de37     control-plane   True

Your cluster cluster.kops-test.vayner.me is ready

@moshevayner
Copy link
Member Author

/retest

1 similar comment
@moshevayner
Copy link
Member Author

/retest

@k8s-ci-robot
Copy link
Contributor

@moshevayner: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kops-e2e-aws-upgrade-k127-ko127-to-klatest-kolatest-many-addons f8569c3 link false /test pull-kops-e2e-aws-upgrade-k127-ko127-to-klatest-kolatest-many-addons

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Copy link
Member

@hakman hakman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @moshevayner! 😄

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 30, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 30, 2024
@k8s-ci-robot k8s-ci-robot merged commit dd7548c into kubernetes:master Jan 30, 2024
@k8s-ci-robot k8s-ci-robot added this to the v1.29 milestone Jan 30, 2024
@moshevayner moshevayner deleted the aws-cni-1.16.2 branch January 30, 2024 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/addons cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants