WIP: Simple baremetal nodes #16139
WIP: Simple baremetal nodes #16139
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This holds the public key for a bare-metal machine. The alternative is to store this in a secret, but a dedicated CRD works better with RBAC - we would rather not grant permissions on secrets if we have an alternative.
Similar to the TPM bootstrapping on GCE (indeed, a lot of the code is modified from there), but we verify the PKI signature against a public key in a Host CRD object.
On bare metal, the nodeupConfig is harder to predict and we will have to use other ways to trigger an update anyway.
b1349c6 to
53d59a8
Compare
|
|
||
| ## Introduction | ||
|
|
||
| kOps has some experimental bare-metal support, specifically for nodes. The idea |
There was a problem hiding this comment.
worth of mentioning that control-plane (and other nodes) should be with public topology? If the topology is private, its going to be difficult to have working cluster internal networking
There was a problem hiding this comment.
if I have understood correctly, the control plane should be able to connect nodes to retrieve like logs. Also nodes should be able to connect control plane (through api loadbalancer). Also node to node connectivity is needed to make CNI working. So basically also that metal host outside cloud needs to have public ip address
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@justinsb: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
The Kubernetes project currently lacks enough contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
|
The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle rotten |
|
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /close |
|
@k8s-triage-robot: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
This is a cleaned-up and revamped version of experimental bare-metal support, whittled down to a handful of commits.
I plan on submitting these PRs individually, but wanted to give the "big picture" also.