Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable Masquerading for Cilium ENI mode #16132

Closed
wants to merge 4 commits into from

Conversation

rifelpet
Copy link
Member

@rifelpet rifelpet commented Nov 29, 2023

This reverts #14694. Enabling masquerading was needed when upgrading from cilium 1.10 to 1.11, but it wasn't understood why this was needed, and it didnt make sense.

Since the cilium 1.14 upgrade, cilium-eni grid tests have started failing (example). Reproing this locally I've confirmed that the tests are failing because pods with hostNetwork=false are timing out reaching pods on other nodes, including the apiserver:

Failed to watch *v1.Node: failed to list *v1.Node: Get "[https://100.64.0.1:443/api/v1/nodes?limit=500&resourceVersion=0](https://100.64.0.1/api/v1/nodes?limit=500&resourceVersion=0)": dial tcp 100.64.0.1:443: i/o timeout

Notice that all failing tests in the grid jobs involve network communication with other pods or kube-apiserver.

Troubleshooting confirmed that the request is leaving the source instance on the instance's default ENI rather than the pod IP's ENI (this is by design of cilium masquerading) and the traffic is dropped. TBH I'm not sure how enabling masquerading would have worked unless there was a bug in cilium 1.11 that has been fixed in 1.14.

With masquerading disabled, almost all of the failing tests pass. The only remaining failures are unrelated to pod networking.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 29, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from rifelpet. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rifelpet
Copy link
Member Author

/test pull-kops-e2e-cni-cilium-eni

1 similar comment
@hakman
Copy link
Member

hakman commented Nov 29, 2023

/test pull-kops-e2e-cni-cilium-eni

@rifelpet rifelpet force-pushed the cilium-eni-masq branch 3 times, most recently from 8f8eddd to 9630751 Compare December 1, 2023 00:27
@k8s-ci-robot
Copy link
Contributor

@rifelpet: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kops-e2e-k8s-gce-cilium 0377987 link true /test pull-kops-e2e-k8s-gce-cilium
pull-kops-e2e-cni-cilium-ipv6 0377987 link false /test pull-kops-e2e-cni-cilium-ipv6
pull-kops-e2e-cni-cilium-etcd 0377987 link true /test pull-kops-e2e-cni-cilium-etcd
pull-kops-e2e-cni-cilium 0377987 link true /test pull-kops-e2e-cni-cilium
pull-kops-e2e-cni-cilium-eni 0377987 link false /test pull-kops-e2e-cni-cilium-eni

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 3, 2024
@k8s-ci-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rifelpet rifelpet closed this Jan 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/api cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants