aws: support custom naming with external ccm

[JBOClara]

Allow to customize ResourceBasedNaming subnet configuration

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: JBOClara (9fc371a, 2437910)

[k8s-ci-robot]

Welcome @JBOClara!

It looks like this is your first PR to kubernetes/kops 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/kops has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @JBOClara. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign johngmyers for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[hakman]

Hi @JBOClara. Did you test this change?
/ok-to-test

[JBOClara]

Hi @hakman

I have tested without applying for now. I need to build a test cluster to test with '--yes' today.

Do I need to add a unit test for this change ?

I'll check the failed tests and make some changes

[k8s-ci-robot]

@JBOClara: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-kops-test	2437910	link	true	/test pull-kops-test
pull-kops-e2e-k8s-aws-calico	2437910	link	true	/test pull-kops-e2e-k8s-aws-calico

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[hakman]

I have tested without applying for now. I need to build a test cluster to test with '--yes' today.
Do I need to add a unit test for this change ?

I think the main focus should be to have a functional approach and we can discuss later what needs to be added or changed to merge the PR. As is at the moment, I don't see this having any effect in tests, as nodes still use resource based names.

To help, 1ea0fd3 is the commit hat removed support for non resource based names.

[JBOClara]

I'm not entirely clear on the reasoning behind the node naming change when using CCM. We're just starting our migration to 1.24.

According to https://cloud-provider-aws.sigs.k8s.io/prerequisites/#node-name-conventions, AWS supports two naming conventions: IP-based or resource-based naming.

We want to be able to use the 'IP name' subnet configuration, but since we manage our VPC and subnet with kops, there's no way to switch this parameter with kops. I tried to change this parameter on a cluster's subnets, but kops rolled back all my changes.

In response to #12864 (comment), it was suggested that if admins don't want to use resource-based domain names, they can create their own shared subnets. However, we want to keep, as far as possible, using our subnets managed by kops.
Could you please clarify why we need to use shared subnets?

[hakman]

I'm not entirely clear on the reasoning behind the node naming change when using CCM. We're just starting our migration to 1.24.

I will try to be as clear as I can.
This was done 2 years ago and the reasons are irrelevant. We asked people that want to keep the old behaviour to contribute it and we will be happy to review the change.
I am not aware of any way to make this work the way you want with latest kOps. I don't think the suggestion in that comment will work anymore. You can try to set the ownership tag on the subnet to "kubernetes.io/cluster/<cluster-name>" = "shared" and kOps will not change it anymore, but that is at best a temporary solution.

[JBOClara]

Ok 👍, thanks for your help, I'm closing this PR