Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

openstack: fix instance group validation if using serverGroupName annotation #16022

Merged
merged 1 commit into from
Oct 15, 2023
Merged

openstack: fix instance group validation if using serverGroupName annotation #16022

merged 1 commit into from
Oct 15, 2023

Conversation

zetaab
Copy link
Member

@zetaab zetaab commented Oct 14, 2023

No description provided.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 14, 2023
@k8s-ci-robot k8s-ci-robot requested a review from hakman October 14, 2023 19:37
@k8s-ci-robot k8s-ci-robot added the area/provider/openstack Issues or PRs related to openstack provider label Oct 14, 2023
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 14, 2023
@zetaab
Copy link
Member Author

zetaab commented Oct 14, 2023

/hold

Still running rolling-update tests for clusters which contains serverGroupName annotation, and cluster which does not have that.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 14, 2023
@zetaab zetaab linked an issue Oct 14, 2023 that may be closed by this pull request
Rolling update with openstack.kops.io/serverGroupName fails #16015
Closed
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 14, 2023
@zetaab zetaab force-pushed the fix/servergroupname branch from 0e5b1d6 to 8dea252 Compare October 14, 2023 20:18
@zetaab
Copy link
Member Author

zetaab commented Oct 14, 2023

/hold cancel

everything seems working fine

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 14, 2023
@zetaab zetaab mentioned this pull request Oct 14, 2023
Merged
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 15, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 15, 2023
@hakman hakman changed the title fix instance group validation if using serverGroupName annotation openstack: fix instance group validation if using serverGroupName annotation Oct 15, 2023
@k8s-ci-robot k8s-ci-robot merged commit efd8444 into kubernetes:master Oct 15, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.29 milestone Oct 15, 2023
k8s-ci-robot added a commit that referenced this pull request Oct 15, 2023
@k8s-ci-robot
Merge pull request #16023 from zetaab/automated-cherry-pick-of-#16022…
529670c 
…-upstream-release-1.28

Automated cherry pick of #16022: fix instance group validation if using serverGroupName
@zetaab zetaab deleted the fix/servergroupname branch October 15, 2023 07:02
@Wieneo
Copy link

Wieneo commented Nov 15, 2023

@zetaab
Sorry for reopening this old issue but we just tried the new kOps version and it seems to break with multiple kOps clusters in one OpenStack project.
kOps update fails because instances from other clusters get marked as "has not yet joined cluster".

@zetaab
Copy link
Member Author

zetaab commented Nov 15, 2023

#15735 so did not help? if not, can you make the issue because it is quite difficult for me to reproduce these because I am not using this feature at all.

@Wieneo Wieneo mentioned this pull request Nov 16, 2023
Closed
@Wieneo
Copy link

Wieneo commented Nov 16, 2023

I have opened #16106, explaining the issue further 🙂

@BrewTestBot BrewTestBot mentioned this pull request May 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hakman hakman hakman approved these changes

@olemarkus olemarkus Awaiting requested review from olemarkus

Assignees

@hakman hakman

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/openstack Issues or PRs related to openstack provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.29
Development

Successfully merging this pull request may close these issues.

Rolling update with openstack.kops.io/serverGroupName fails
4 participants
@zetaab @k8s-ci-robot @Wieneo @hakman