Add dependabot #410
Add dependabot #410
Conversation
Signed-off-by: Luca Comellini <luca.com@gmail.com>
|
Welcome @lucacome! |
|
/triage accepted |
|
Add it to my to-do list. |
There was a problem hiding this comment.
You may be more familiar with the dependabot configuration. Please double-check it. @pohly
| directories: | ||
| - "**/*" | ||
| schedule: | ||
| interval: daily |
There was a problem hiding this comment.
| interval: daily | |
| interval: "weekly" |
Does the scheduling interval need to be set to daily? Is it too frequent? I think a weekly run is enough.
There was a problem hiding this comment.
I don't think it makes much of a difference, with weekly it's more likely that you'll get a bunch of PRs all at once and reach the limit of open PRs
There was a problem hiding this comment.
Which "limit of open PRs"?
klog does not have external Go dependencies. I am unsure what kind of PRs dependabot will create here and how useful they will be. I suppose we can try it out...
/lgtm
/assign @dims
For approval.
There was a problem hiding this comment.
@pohly https://docs.github.com/en/code-security/dependabot/dependabot-version-updates/configuration-options-for-the-dependabot.yml-file#open-pull-requests-limit
by default dependabot only opens 5 PRs for every package-ecosystem at a time
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lucacome, pohly The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Looks like dependabot is not enabled for the repo maybe? It should've opened a few PRs by now |
|
PRs for what? |
|
GitHub Actions |
What this PR does / why we need it:
Adds dependabot to keep dependencies up to date
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.
Release note: