terraform: cleanup prow terraform #2850
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Specifically: - merge locals blocks - move workload_identity_service_accounts from list to map - terraform fmt - fix typo in wisa module invocation - depend on module.project.project_id
Specifically: - merge locals blocks - concert workload_identity_service_accounts to map - terraform fmt - fixup wisa module invocation - depend on module.project.project_id
Move resources out of main.tf into their own files to reduce the set of resources someone needs to look at all at once to make a change - secrets.tf - serviceaccounts.tf - external-ips.tf
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: spiffxp The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Move resources out of main.tf into their own files to reduce the set of resources someone needs to look at all at once to make a change - secrets.tf - serviceaccounts.tf - external-ips.tf
09ed0d1 to
674eec8
Compare
|
/lgtm please remove hold when ready @spiffxp (or if you need additional eyes) |
|
/lgtm |
|
/hold cancel |
|
Ran |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related:
Miscellaneous cleanup for both prow projects
The goal in splitting up is to point someone looking to add a new secret or service account to a file that looks much less scary than a single monolithic terraform file