Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clusters/aaa: upgrade kubernetes-external-secrets to v8.1.2 #2226

Merged
merged 2 commits into from
Jun 16, 2021

Conversation

spiffxp
Copy link
Member

@spiffxp spiffxp commented Jun 15, 2021

This upgrades kubernetes-external-secrets on aaa to the latest version for:

  • CVE fixes
  • v1 of the ExternalSecret CRD

This needs to be manually deployed

This will unblock #2224

Migrating all secrets to ExternalSecrets ref: #2220

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jun 15, 2021
@k8s-ci-robot k8s-ci-robot requested review from dims and thockin June 15, 2021 21:30
@k8s-ci-robot k8s-ci-robot added area/terraform Terraform modules, testing them, writing more of them, code in infra/gcp/clusters/ wg/k8s-infra approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 15, 2021
@spiffxp
Copy link
Member Author

spiffxp commented Jun 15, 2021

/cc @ameukam
FYI

@k8s-ci-robot k8s-ci-robot requested a review from ameukam June 15, 2021 21:32
@spiffxp spiffxp force-pushed the upgrade-aaa-k-e-s branch from 2085874 to 6a21df2 Compare June 15, 2021 22:10
@spiffxp
Copy link
Member Author

spiffxp commented Jun 15, 2021

Deployed

$ git checkout upgrade-aaa-k-e-s && cd kubernetes-external-secrets
$ k --context=aaa apply -f .
serviceaccount/kubernetes-external-secrets configured
service/kubernetes-external-secrets-metrics created
deployment.apps/kubernetes-external-secrets configured
customresourcedefinition.apiextensions.k8s.io/externalsecrets.kubernetes-client.io configured
clusterrole.rbac.authorization.k8s.io/kubernetes-external-secrets configured
clusterrolebinding.rbac.authorization.k8s.io/kubernetes-external-secrets configured
clusterrolebinding.rbac.authorization.k8s.io/kubernetes-external-secrets-auth configured
$ k --context=aaa --namespace=kubernetes-external-secrets delete service/kubernetes-external-secrets
service "kubernetes-external-secrets" deleted

But I'm not seeing the triageparty-release external secret like I would expect?

$ k --context=aaa get externalsecrets -A
No resources found

@spiffxp
Copy link
Member Author

spiffxp commented Jun 15, 2021

Checked out #2224 and deploy the prow externalsecret to confirm it's working...

spiffxp@cloudshell:~/k8s.io/prow (kubernetes-public)$ k apply -f .
persistentvolumeclaim/ghproxy unchanged
deployment.apps/ghproxy configured
service/ghproxy unchanged
serviceaccount/ghproxy unchanged
externalsecret.kubernetes-client.io/k8s-infra-ci-robot-github-token created

Oh right, copy-paste on the service account

$ k --context=aaa get externalsecrets -A
NAMESPACE   NAME                              LAST SYNC   STATUS                                                                                                                                                                                                                                                                                                                                                                                                                                               AGE
prow        k8s-infra-ci-robot-github-token   2s          ERROR, 16 UNAUTHENTICATED: Failed to retrieve auth metadata with error: Could not refresh access token: A Forbidden error was returned while attempting to retrieve an access token for the Compute Engine built-in service account. This may be because the Compute Engine instance does not have the correct permission scopes specified: Could not refresh access token: Unsuccessful response status code. Request failed with status code 403   43s

Changes from prow's copy:
- don't expose kubernetes-external-secrets-metrics for now (want to
  redo ensure-static-ips.sh as terraform in a different PR)
- different service account
@spiffxp spiffxp force-pushed the upgrade-aaa-k-e-s branch from 6a21df2 to bd32c9e Compare June 15, 2021 22:25
@spiffxp
Copy link
Member Author

spiffxp commented Jun 15, 2021

OK, it's happy now

$ k --context=aaa get externalsecrets -A
NAMESPACE   NAME                              LAST SYNC   STATUS    AGE
prow        k8s-infra-ci-robot-github-token   3s          SUCCESS   3m35s

I'm going to leave this WIP until I can figure out what's up with triage-party

@spiffxp spiffxp changed the title [wip]: clusters/aaa: upgrade kubernetes-external-secrets to v8.1.2 clusters/aaa: upgrade kubernetes-external-secrets to v8.1.2 Jun 16, 2021
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 16, 2021
@spiffxp
Copy link
Member Author

spiffxp commented Jun 16, 2021

Removed [wip], everything in here has already been deployed. I was informed by @ameukam out of band that triage party is expected to not quite be working correctly.

Comment on lines -2 to -8
apiVersion: v1
kind: ServiceAccount
metadata:
name: kubernetes-external-secrets
namespace: kubernetes-external-secrets
annotations:
iam.gke.io/gcp-service-account: kubernetes-external-secrets@kubernetes-public.iam.gserviceaccount.com
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was moved to kubernetes-external-secrets-serviceaccounts.yaml

@dims
Copy link
Member

dims commented Jun 16, 2021

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 16, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 5973617 into kubernetes:main Jun 16, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.22 milestone Jun 16, 2021
@spiffxp spiffxp deleted the upgrade-aaa-k-e-s branch June 16, 2021 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/terraform Terraform modules, testing them, writing more of them, code in infra/gcp/clusters/ cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants