-
Notifications
You must be signed in to change notification settings - Fork 854
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
clusters/aaa: upgrade kubernetes-external-secrets to v8.1.2 #2226
Conversation
/cc @ameukam |
2085874
to
6a21df2
Compare
Deployed
But I'm not seeing the triageparty-release external secret like I would expect?
|
Checked out #2224 and deploy the prow externalsecret to confirm it's working...
Oh right, copy-paste on the service account
|
Changes from prow's copy: - don't expose kubernetes-external-secrets-metrics for now (want to redo ensure-static-ips.sh as terraform in a different PR) - different service account
6a21df2
to
bd32c9e
Compare
OK, it's happy now
I'm going to leave this WIP until I can figure out what's up with triage-party |
Removed |
apiVersion: v1 | ||
kind: ServiceAccount | ||
metadata: | ||
name: kubernetes-external-secrets | ||
namespace: kubernetes-external-secrets | ||
annotations: | ||
iam.gke.io/gcp-service-account: kubernetes-external-secrets@kubernetes-public.iam.gserviceaccount.com |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was moved to kubernetes-external-secrets-serviceaccounts.yaml
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dims, spiffxp The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This upgrades kubernetes-external-secrets on aaa to the latest version for:
This needs to be manually deployed
This will unblock #2224
Migrating all secrets to ExternalSecrets ref: #2220