-
Notifications
You must be signed in to change notification settings - Fork 854
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace master branch references with main #1764
Conversation
/lgtm |
i can do this /approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dims, nikhita The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@dims - when you push these nginx changes to prod you also need to bounce
the nginx instances - they don't self-restart.
…On Tue, Mar 16, 2021 at 5:26 AM Kubernetes Prow Robot < ***@***.***> wrote:
Merged #1764 <#1764> into main.
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
<#1764 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABKWAVCMLVXI5VYFJPLNWRDTD5FBBANCNFSM4YX2K6NQ>
.
|
@thockin aha! could we add any extra step to the README please? usually i just read that and execute step by step :) |
Which README? The one that says to `make deploy` (which doesn't exist, LOL).
…On Tue, Mar 16, 2021 at 9:30 AM Davanum Srinivas ***@***.***> wrote:
@thockin aha! could we add any extra step to the README please? usually i just read that and execute step by step :)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
LOL |
Ref: #1597 (comment)
/assign @spiffxp
/hold
hold should be removed by someone who can deploy the k8s.io changes