opentelemetry documentation #9144
Conversation
|
@esigo: This issue is currently awaiting triage. If Ingress contributors determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Hi @esigo. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
depends on #9062 |
| enable-opentelemetry: "true" | ||
| opentelemetry-config: "/etc/nginx/opentelemtry.toml" | ||
| opentelemetry-operation-name: "HTTP $request_method $service_name $uri" | ||
| OpentelemetryTrustIncomingSpan: "true" |
There was a problem hiding this comment.
Should OpentelemetryTrustIncomingSpan be updated to opentelemetry-trust-incoming-span?
| otel-sampler-parent-based: "false" | ||
| metadata: | ||
| name: ingress-nginx-controller | ||
| namespace: kube-system |
There was a problem hiding this comment.
Looks like the demo deploys ingress-nginx-controller to ingress-nginx namespace, not kube-system.
| kind: ConfigMap | ||
| data: | ||
| enable-opentelemetry: "true" | ||
| opentelemetry-config: "/etc/nginx/opentelemtry.toml" |
| # sets whether or not to trust incoming telemetry spans | ||
| opentelemetry-trust-incoming-span | ||
|
|
||
| # specifies the port to use when uploading traces, Default: 9411 |
There was a problem hiding this comment.
| # specifies the port to use when uploading traces, Default: 9411 | |
| # specifies the port to use when uploading traces, Default: 4317 | |
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/hold |
|
/unhold |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: esigo, strongjz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/close dup of #9062 |
What this PR does / why we need it:
Types of changes
Which issue/s this PR fixes
related to #9016 3
How Has This Been Tested?
Checklist:
Does my pull request need a release note?
Any user-visible or operator-visible change qualifies for a release note. This could be a:
No release notes are required for changes to the following:
For more tips on writing good release notes, check out the Release Notes Handbook