Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix opentelemetry-cpp-contrib sha256 #8588

Merged

Conversation

esigo
Copy link
Member

@esigo esigo commented May 15, 2022

What this PR does / why we need it:

This PR fixes the sha256sum hash used in #8585.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation only

Which issue/s this PR fixes

How Has This Been Tested?

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I've read the CONTRIBUTION guide
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels May 15, 2022
@k8s-ci-robot
Copy link
Contributor

@esigo: This issue is currently awaiting triage.

If Ingress contributors determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels May 15, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @esigo. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-priority size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 15, 2022
@k8s-ci-robot k8s-ci-robot requested review from bowei and ElvinEfendi May 15, 2022 09:23
@longwuyuan
Copy link
Contributor

/ok-to-test

@esigo is this sha good for 6 months, approximately

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 15, 2022
@longwuyuan
Copy link
Contributor

/assign @rikatz

Ricardo, please advise if the merge of the previous opentelemetry PR should have fire cloudbuild or not.
Also, this PR merge should fire cloudbuild is it not ? Or is there something else needed to be done to fire cloudbuild ?

@esigo
Copy link
Member Author

esigo commented May 15, 2022

/ok-to-test

@esigo is this sha good for 6 months, approximately

@longwuyuan the sha should be good until you change the contrib commit hash.

export OPENTELEMETRY_CONTRIB_COMMIT=6467ec2e4d67b08b44580b7eb7a298786f4eef91

@longwuyuan
Copy link
Contributor

Thanks @esigo . What is your release cadence. Just trying to know when we will have to bump/change/update/pgrade.

@esigo
Copy link
Member Author

esigo commented May 15, 2022

Thanks @esigo . What is your release cadence. Just trying to know when we will have to bump/change/update/pgrade.

@longwuyuan we normally have monthly releases.

@rikatz
Copy link
Contributor

rikatz commented May 16, 2022

/lgtm
/approve

Thanks

@rikatz
Copy link
Contributor

rikatz commented May 16, 2022

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 16, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: esigo, rikatz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 16, 2022
@k8s-ci-robot k8s-ci-robot merged commit 2d2ec55 into kubernetes:main May 16, 2022
@esigo esigo deleted the fix-opentelemetry-coontrib-sha256 branch May 16, 2022 15:03
rchshld pushed a commit to joomcode/ingress-nginx that referenced this pull request May 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants