Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

force external_auth requests to http/1.1 #1787

Merged
merged 1 commit into from
Dec 4, 2017
Merged

force external_auth requests to http/1.1 #1787

merged 1 commit into from
Dec 4, 2017
+1 −0

Conversation

mindw
Copy link
Contributor

@mindw mindw commented Dec 2, 2017

What this PR does / why we need it:
forces external auth subrequests to use http 1.1

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #1784

Special notes for your reviewer:

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 2, 2017
@k8s-reviewable
Copy link

This change is Reviewable

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 2, 2017
@coveralls
Copy link

Coverage Status

Coverage remained the same at 36.605% when pulling 8325ca9 on mindw:patch-2 into 99d3e9e on kubernetes:master.

@petvaa01 petvaa01 mentioned this pull request Dec 4, 2017
Closed
@aledbf
Copy link
Member

aledbf commented Dec 4, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 4, 2017
@aledbf
Copy link
Member

aledbf commented Dec 4, 2017

@mindw thanks!

@aledbf aledbf merged commit 5373348 into kubernetes:master Dec 4, 2017
@mindw mindw deleted the patch-2 branch December 4, 2017 19:38
@day0ops day0ops mentioned this pull request Jan 21, 2018
Closed
@mrdima mrdima mentioned this pull request Aug 13, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@aledbf aledbf

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Request to URL defined with ingress.kubernetes.io/auth-url done with HTTP/1.0
5 participants
@mindw @k8s-reviewable @coveralls @aledbf @k8s-ci-robot