Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor annotations #1662

Merged
merged 6 commits into from
Nov 11, 2017
Merged

Refactor annotations #1662

merged 6 commits into from
Nov 11, 2017

Conversation

aledbf
Copy link
Member

@aledbf aledbf commented Nov 7, 2017 •
edited
Loading

What this PR does / why we need it:

This PR improves the parsing of ingress annotations and avoid unnecessary parsing if no changes occurred.

fixes #1274
fixes #1436

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 7, 2017
@k8s-reviewable
Copy link

This change is Reviewable

@k8s-ci-robot k8s-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Nov 7, 2017
@aledbf aledbf force-pushed the refactor-annotations branch 4 times, most recently from 7331027 to 94c3abd Compare November 7, 2017 21:58
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Nov 7, 2017
@aledbf aledbf force-pushed the refactor-annotations branch from 4cfd6eb to 197e420 Compare November 7, 2017 22:28
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.4%) to 36.7% when pulling 197e420b3e91a605659396cc6472290088d71b26 on aledbf:refactor-annotations into 9cec069 on kubernetes:master.

@aledbf aledbf force-pushed the refactor-annotations branch from 197e420 to c88b8cf Compare November 8, 2017 00:11
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.4%) to 36.7% when pulling c88b8cf676c23d9178aff15bcfd40f4f34e8ea47 on aledbf:refactor-annotations into 9cec069 on kubernetes:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.2%) to 36.869% when pulling 9800da0e7542aef8ac46f7d336daed1e21165b4f on aledbf:refactor-annotations into 9cec069 on kubernetes:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.3%) to 36.808% when pulling a258f10acdabc4c92b08177ea28291fba5e0f33c on aledbf:refactor-annotations into 9cec069 on kubernetes:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.3%) to 36.832% when pulling f7f00f5716ed7069151156cfc18b0e77d93646e1 on aledbf:refactor-annotations into 9cec069 on kubernetes:master.

@aledbf aledbf mentioned this pull request Nov 9, 2017
Closed
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.3%) to 36.795% when pulling 2c33231bab2ac0f8571a9588fc95381162b588b4 on aledbf:refactor-annotations into 9cec069 on kubernetes:master.

@aledbf aledbf force-pushed the refactor-annotations branch 3 times, most recently from 52ccbb8 to fbd0df2 Compare November 11, 2017 17:30
@coveralls
Copy link

Coverage Status

Changes Unknown when pulling fbd0df2 on aledbf:refactor-annotations into ** on kubernetes:master**.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling fbd0df2 on aledbf:refactor-annotations into ** on kubernetes:master**.

@aledbf aledbf changed the title WIP: Refactor annotations Refactor annotations Nov 11, 2017
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 11, 2017
@coveralls
Copy link

Coverage Status

Changes Unknown when pulling fbd0df2 on aledbf:refactor-annotations into ** on kubernetes:master**.

@aledbf aledbf force-pushed the refactor-annotations branch from fbd0df2 to 4c1c707 Compare November 11, 2017 17:53
@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 4c1c707 on aledbf:refactor-annotations into ** on kubernetes:master**.

@aledbf aledbf merged commit 39c3085 into kubernetes:master Nov 11, 2017
@aledbf aledbf mentioned this pull request Nov 13, 2017
Closed
@aledbf aledbf deleted the refactor-annotations branch November 24, 2017 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

nginx-specific annotations should say nginx Verbose messages about no host matching TLS section
4 participants
@aledbf @k8s-reviewable @coveralls @k8s-ci-robot