-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
helm: Copy otel distroless flag to daemonset #10391
Conversation
This flag was added to the controller deployment, but not the controller daemonset.
✅ Deploy Preview for kubernetes-ingress-nginx ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
This issue is currently awaiting triage. If Ingress contributors determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Welcome @danopia! |
Hi @danopia. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: danopia The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Looking at the 'needs rebase', I believe #10240 merged this fix shortly after I was here, so I'm closing this |
What this PR does / why we need it:
This flag was added to the controller deployment, but not the controller daemonset.
true
in promote distroless otel init image #10257I'm applying both of these deployment changes to the daemonset in one go.
Types of changes
Which issue/s this PR fixes
Updating to
1.8.2
/ingress-nginx-4.7.2
with opentelemetry enabled on a daemonset resulted in a broken installation, because the DaemonSet pod went intoInit:RunContainerError
.I didn't file an issue first since the PR change was minimal.
How Has This Been Tested?
I ran helm on my modified chart, and it produced a
DaemonSet
with the correct entrypoint for distroless.Is there a better way to test this sort of difference between
DaemonSet
andDeployment
? This is not the first time that theDamonset
was neglected with the otel initcontainer.Checklist: