Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update e2e framework for ILB and add basic test #824

Closed
wants to merge 1 commit into from
Closed

Update e2e framework for ILB and add basic test #824

wants to merge 1 commit into from

Conversation

spencerhance
Copy link
Contributor

@spencerhance spencerhance commented Aug 13, 2019 •
edited
Loading

Adds HasAlphaRegionResource() to handle L7-ILB and adds it as a feature. Ideally we should switch e2e to use composites and ResourceVersions.

The actual tests will be added in a seperate PR.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 13, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @spencerhance. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spencerhance
Copy link
Contributor Author

/assign @bowei

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 13, 2019
@k8s-ci-robot k8s-ci-robot requested review from MrHohn and thockin August 13, 2019 22:45
@rramkumar1
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 14, 2019
rramkumar1
rramkumar1 reviewed Aug 14, 2019
View reviewed changes
pkg/fuzz/features/ilb.go Outdated
"net/http"
)

// BackendConfigExample is an example of how a Feature will integrate with the
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix this comment

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: spencerhance
To complete the pull request process, please assign bowei
You can assign the PR to them by writing /assign @bowei in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@spencerhance
Copy link
Contributor Author

/hold
I think i'm missing some logic here

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 14, 2019
@bowei bowei changed the title Update e2e framework for ILB and add basic test WIP: Update e2e framework for ILB and add basic test Aug 15, 2019
@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 15, 2019
@spencerhance spencerhance force-pushed the l7-ilb-e2e-tests branch 2 times, most recently from 8fac91e to da57c9a Compare August 16, 2019 02:58
@bowei
Copy link
Member

bowei commented Aug 20, 2019

this mostly looks ok.

@spencerhance spencerhance force-pushed the l7-ilb-e2e-tests branch 4 times, most recently from 7bb28e8 to ace43e5 Compare August 20, 2019 20:16
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 21, 2019
@spencerhance spencerhance changed the title WIP: Update e2e framework for ILB and add basic test Update e2e framework for ILB and add basic test Aug 21, 2019
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 21, 2019
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 21, 2019
@spencerhance
Copy link
Contributor Author

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 21, 2019
@spencerhance
Copy link
Contributor Author

@bowei this is ready for review

@spencerhance spencerhance mentioned this pull request Sep 5, 2019
Merged
@spencerhance
Copy link
Contributor Author

closing in favor of #843

@spencerhance spencerhance deleted the l7-ilb-e2e-tests branch September 27, 2019 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rramkumar1 rramkumar1 rramkumar1 left review comments

@MrHohn MrHohn Awaiting requested review from MrHohn

@thockin thockin Awaiting requested review from thockin

Assignees

@bowei bowei

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@spencerhance @k8s-ci-robot @rramkumar1 @bowei