Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to go modules #735

Merged
merged 3 commits into from
May 17, 2019
Merged

Switch to go modules #735

merged 3 commits into from
May 17, 2019

Conversation

spencerhance
Copy link
Contributor

@spencerhance spencerhance commented Apr 20, 2019 •
edited
Loading

  • Updates vendor
  • Pins all dependencies to their exact version

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 20, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @spencerhance. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Apr 20, 2019
@k8s-ci-robot k8s-ci-robot requested review from freehan and thockin April 20, 2019 00:10
@spencerhance spencerhance force-pushed the switch-to-go-modules branch from 3cdb828 to 9e7e2a3 Compare April 20, 2019 00:11
@freehan
Copy link
Contributor

freehan commented Apr 20, 2019

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 20, 2019
@rramkumar1
Copy link
Contributor

@spencerhance My understanding was that for us to transition to modules, all our dependencies need to be on modules as well? Is that true?

@spencerhance
Copy link
Contributor Author

@rramkumar1 That i'm not sure. It seemed to me that it would handle non-module dependencies as before but I'm still investigating.

@spencerhance spencerhance force-pushed the switch-to-go-modules branch from dcb0a53 to ab6514e Compare April 23, 2019 22:46
@k8s-ci-robot k8s-ci-robot added sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Apr 23, 2019
@spencerhance spencerhance force-pushed the switch-to-go-modules branch from ab6514e to f82a7bc Compare May 1, 2019 14:46
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 1, 2019
@spencerhance spencerhance changed the title [WIP] Switch to go modules Switch to go modules May 1, 2019
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 1, 2019
@rramkumar1
Copy link
Contributor

rramkumar1 commented May 8, 2019 •
edited
Loading

@spencerhance Do you mind adding some docs under docs/contrib for how to update dependencies?

I initially had some stuff here (https://github.com/kubernetes/ingress-gce/blob/master/docs/contrib/dev-setup.md#other-considerations). If its not worth expanding on that, then that's fine.

@spencerhance spencerhance force-pushed the switch-to-go-modules branch 3 times, most recently from 7dce7c9 to 26f93df Compare May 9, 2019 19:44
@bowei
Copy link
Member

bowei commented May 9, 2019

/assign

@bowei
Copy link
Member

bowei commented May 9, 2019

can we try limiting this update to just moving to go modules? this change looks like it pulls a bunch of other stuff in, which makes it harder to review

@spencerhance
Copy link
Contributor Author

@bowei I ran into some complications without running a dep ensure -update but I'll see if I can remove it.

@spencerhance spencerhance force-pushed the switch-to-go-modules branch from b60f59f to 64c7548 Compare May 9, 2019 22:17
@spencerhance spencerhance force-pushed the switch-to-go-modules branch from 64c7548 to ccd881f Compare May 9, 2019 22:19
@spencerhance
Copy link
Contributor Author

@bowei I got rid of the composite changes and associated api version update so all changes should be localized to modules and vendor/ now

@bowei
Copy link
Member

bowei commented May 17, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 17, 2019
@bowei
Copy link
Member

bowei commented May 17, 2019

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bowei, spencerhance

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 17, 2019
@k8s-ci-robot k8s-ci-robot merged commit c33674c into kubernetes:master May 17, 2019
@spencerhance spencerhance deleted the switch-to-go-modules branch June 5, 2019 02:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@freehan freehan Awaiting requested review from freehan

@thockin thockin Awaiting requested review from thockin

Assignees

@bowei bowei

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@spencerhance @k8s-ci-robot @freehan @rramkumar1 @bowei