Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update vendored k/k to remove glog usage #669

Merged
merged 2 commits into from
Mar 8, 2019
Merged

Update vendored k/k to remove glog usage #669

merged 2 commits into from
Mar 8, 2019

Conversation

rramkumar1
Copy link
Contributor

@rramkumar1 rramkumar1 commented Mar 7, 2019 •
edited
Loading

Follow up to #666.

Remove all uses of glog inside of vendored k/k so that we are able to call klog.InitFlags() without getting an error that flags are being initialized twice.

The PR is split into two commits:

  1. Vendor and associated changes to get 'make test' to pass
  2. Wrap klog.InitFlags() inside of an init() so it's only called once.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Mar 7, 2019
@k8s-ci-robot k8s-ci-robot added sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/storage Categorizes an issue or PR as relevant to SIG Storage. labels Mar 7, 2019
@rramkumar1 rramkumar1 force-pushed the update-vendor-to-remove-glog branch from 90641b3 to 6cea301 Compare March 7, 2019 03:16
@rramkumar1 rramkumar1 removed sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/storage Categorizes an issue or PR as relevant to SIG Storage. labels Mar 7, 2019
@rramkumar1 rramkumar1 changed the title Update vendor to remove glog Update vendor to remove glog usage Mar 7, 2019
@rramkumar1 rramkumar1 changed the title Update vendor to remove glog usage Update vendored k/k to remove glog usage Mar 7, 2019
@rramkumar1 rramkumar1 force-pushed the update-vendor-to-remove-glog branch from 6cea301 to f7c511a Compare March 7, 2019 03:46
@k8s-ci-robot k8s-ci-robot added sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/storage Categorizes an issue or PR as relevant to SIG Storage. labels Mar 7, 2019
@rramkumar1 rramkumar1 force-pushed the update-vendor-to-remove-glog branch from f7c511a to 6ecda41 Compare March 7, 2019 03:51
@rramkumar1 rramkumar1 force-pushed the update-vendor-to-remove-glog branch from 6ecda41 to c6d0f0c Compare March 7, 2019 23:54
@bowei
Copy link
Member

bowei commented Mar 8, 2019

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 8, 2019
@rramkumar1 rramkumar1 merged commit c2cb083 into kubernetes:master Mar 8, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bowei, rramkumar1

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@a-robinson a-robinson Awaiting requested review from a-robinson

@apelisse apelisse Awaiting requested review from apelisse

Assignees

@bowei bowei

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rramkumar1 @bowei @k8s-ci-robot