Add support to enable single ingress check #2179
Conversation
|
Hi @songrx1997. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/ok-to-test |
| if len(args) == 0 { | ||
| output = ingress.Check("", namespace, client, beconfigClient, feConfigClient) | ||
| } else { | ||
| output = ingress.Check(args[0], namespace, client, beconfigClient, feConfigClient) | ||
| } | ||
|
|
There was a problem hiding this comment.
This check is repeated again in ingress.Check when you verify whether the ingress name is empty or not. Split into ingress.Check and ingress.CheckAllIngresses.
Then rename the the existing CheckAllIngress to something like RunChecks
0c0678c to
47ca694
Compare
47ca694 to
2dab557
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: songrx1997, swetharepakula The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/assign @swetharepakula