Rename syncer and endpoint metrics to match Monarch #2103
Conversation
|
Hi @sawsa307. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/assign @swetharepakula |
pkg/neg/metrics/endpoint_metrics.go
Outdated
| @@ -24,8 +24,8 @@ const ( | |||
| endpointState = "endpoint_state" | |||
| endpointSliceState = "endpoint_slice_state" | |||
There was a problem hiding this comment.
I think we also have to change the metric labels?
pkg/neg/metrics/endpoint_metrics.go
Outdated
| @@ -24,8 +24,8 @@ const ( | |||
| endpointState = "endpoint_state" | |||
| endpointSliceState = "endpoint_slice_state" | |||
|
|
|||
| endpointStateKey = "neg_sync_endpoint_state" | |||
| endpointSliceStateKey = "neg_sync_endpoint_slice_state" | |||
| endpointStateKey = "syncer_endpoint_state" | |||
There was a problem hiding this comment.
Since we are anyway making some changes here, another minor thing that I wanted to bring up: Can we not declare these constants since they aren't used anywhere and only make the naming more confusing and really affect readability?
I understand that there is a precedence here but I'm expecting to change that as well in future PRs
There was a problem hiding this comment.
Sounds good. Let's start it now!
Rename metrics name and key to match monarch definition.
1f19674 to
517b0c5
Compare
|
/ok-to-test |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sawsa307, swetharepakula The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Rename metrics name and key to match monarch definition.