Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Cherry-pick #2063, #2067 to 1.22] Fix a case when regional instance group l… #2064

Merged
merged 2 commits into from
Apr 13, 2023
Merged

[Cherry-pick #2063, #2067 to 1.22] Fix a case when regional instance group l… #2064

merged 2 commits into from
Apr 13, 2023

Conversation

mmamczur
Copy link
Contributor

@mmamczur mmamczur commented Apr 4, 2023

…inker has to add a backend to the list of already linked backends.

The previous code would set the backends to only the new instance groups and later cause the controller to flip new/old backends on each refresh.

@mmamczur
[Cherry-pick kubernetes#2063 to 1.22] Fix a case when regional instan…
d42e104 
…ce group linker has to add a backend to the list of already linked backends.

The previous code would set the backends to only the new instance groups and later cause the controller to flip new/old backends on each refresh.
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 4, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @mmamczur. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot requested review from aojea and MrHohn April 4, 2023 13:59
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 4, 2023
@panslava
Copy link
Contributor

panslava commented Apr 4, 2023

/hold we missed the case when IG gets removed, let's fix it first

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 4, 2023
@panslava
Copy link
Contributor

panslava commented Apr 7, 2023

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 7, 2023
@panslava
Copy link
Contributor

panslava commented Apr 12, 2023 •
edited
Loading

@mmamczur can you add to this PR also commit that fixes deletion of IGs? (from here #2067)

/assign @cezarygerard

Cezary could you please take a look (after another commit is added), I think this is important change

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 13, 2023
@mmamczur mmamczur changed the title [Cherry-pick #2063 to 1.22] Fix a case when regional instance group l… [Cherry-pick #2063, #2067 to 1.22] Fix a case when regional instance group l… Apr 13, 2023
@mmamczur
Copy link
Contributor Author

@mmamczur can you add to this PR also commit that fixes deletion of IGs? (from here #2067)

/assign @cezarygerard

Cezary could you please take a look (after another commit is added), I think this is important change

Added

@cezarygerard
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 13, 2023
@panslava
Copy link
Contributor

/lgtm
/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 13, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cezarygerard, mmamczur, panslava

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [cezarygerard,panslava]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 874c52c into kubernetes:release-1.22 Apr 13, 2023
@mmamczur mmamczur deleted the cherry-pick#2063-to-1.22 branch April 10, 2024 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aojea aojea Awaiting requested review from aojea

@MrHohn MrHohn Awaiting requested review from MrHohn

Assignees

@cezarygerard cezarygerard

@panslava panslava

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mmamczur @k8s-ci-robot @panslava @cezarygerard