Update k8s-cloud-provider to v1.23.0 for new IPv6 field in NEG API #2047
Conversation
…or new IPv6 field in NEG API
|
Hi @gauravkghildiyal. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/ok-to-test |
| }, | ||
| Timeout: 5 * time.Second, |
There was a problem hiding this comment.
this is an important change, 5 seconds is ok for all APIs?
There was a problem hiding this comment.
oh, is only metadata, right?
I assume that is ok then
| @@ -1,5 +1,5 @@ | |||
| /* | |||
| Copyright 2022 The Kubernetes Authors. | |||
| Copyright 2023 The Kubernetes Authors. | |||
There was a problem hiding this comment.
we have to check this, I think we should not be updating the dates, but is not a big deal
|
/lgtm Thanks |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aojea, gauravkghildiyal The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
No description provided.