Use Patch when syncing GCP BackendService. Linking backend groups still uses Update #2043
Conversation
|
Hi @gauravkghildiyal. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/ok-to-test |
pkg/backends/syncer.go
Outdated
| @@ -305,6 +305,9 @@ func ensureProtocol(be *composite.BackendService, p utils.ServicePort) (needsUpd | |||
| if be.Protocol == string(p.Protocol) { | |||
| return false | |||
| } | |||
|
|
|||
| fmt.Printf("protocol needs change; got be = %+v, want protocol = %v\n", be, p.Protocol) | |||
There was a problem hiding this comment.
Should this be a log line instead?
There was a problem hiding this comment.
Deleted. That log line shouldn't exist. I'm not really sure how it got there. I don't remember adding it.
d3139cf to
6779ac4
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gauravkghildiyal, swetharepakula The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/assign @swetharepakula