[Cherry pick #1973] Only use endpoint slices to generate network endpoints #1997
Conversation
* remove Endpoints code path and only use EndpointSlices for endpoint decisions * removes --enable-endpoints-slices flag and makes that code path default and only option
The neg syncer was doing some wrong assumptions: 1. Endpoints that are not Ready can have Pods with deletionTimestamp not nil. The Endpoint and EndpointSlice controller will remove the Pod from the corresponding object once it gets deleted (DeletionTimestamp != nil) 2. Any pod with deletionTimestamp == nil is valid, this is the most dangerous assumption, since a pod can be Unready and be used.
* terminating pods are already removed from the endpoints from the EPS, so this check is no longer needed. * this check was a remanent of using endpoints as the source of truth since endpoints did not have a terminating field
|
Hi @gauravkghildiyal. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/ok-to-test |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gauravkghildiyal, swetharepakula The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Cherry pick of #1973
/assign @swetharepakula