Fix NEG endpoint attachment for L4 NEGs.

[mmamczur]

The L4 EndpointCalculators do not compute pod endpoints data. It always failed checks in CheckEndpointInfo but the failure was ignored. Now the code returns upon failure after changes from ff4751f. This change skips the checks for calculators that don't return the pods data as these checks compare it with endpoints from slices.

[k8s-ci-robot]

Hi @mmamczur. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[mmamczur]

/assign sawsa307

[k8s-ci-robot]

@mmamczur: GitHub didn't allow me to assign the following users: sawsa307.

Note that only kubernetes members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign sawsa307

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[aojea]

/ok-to-test
/assign @swetharepakula
@sawsa307

[sawsa307]

lgtm. Thanks!

[k8s-ci-robot]

@sawsa307: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mmamczur, sawsa307
Once this PR has been reviewed and has the lgtm label, please ask for approval from swetharepakula. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[swetharepakula]

I do think this fixes the issue for L4 but it is adding another layer of complexity to an already complicated piece of code. I would prefer to revert the original metrics PR instead.

cc/ @sawsa307

[aojea]

/hold

the original PR was reverted in #1980

[sawsa307]

/hold

the original PR was reverted in #1980

#1982 is the actual revert. #1980 is a PR dependent on #1982 so it is reverted as well.

[k8s-ci-robot]

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.