Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make verify #1913

Closed
wants to merge 1 commit into from
Closed

make verify #1913

wants to merge 1 commit into from

Conversation

aojea
Copy link
Member

@aojea aojea commented Jan 25, 2023

It seems we were not running correctly the verify, this PR

  • adds verify and update targets to the makefile
  • split the verify options into different scripts to simplify its maintainnce
  • fix one gofmt error

The generation still doesn't work, it will be fixed by #1884 but this PR adds an option to verify the code generated is correct

Next step is to add a new job to run make verify on the CI kubernetes/test-infra#28507

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 25, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: aojea
Once this PR has been reviewed and has the lgtm label, please assign swetharepakula for approval by writing /assign @swetharepakula in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 25, 2023
@aojea
Copy link
Member Author

aojea commented Jan 25, 2023

/retest

1 similar comment
@aojea
Copy link
Member Author

aojea commented Jan 25, 2023

/retest

@aojea
Copy link
Member Author

aojea commented Jan 25, 2023

/test pull-ingress-gce-test

1 similar comment
@aojea
Copy link
Member Author

aojea commented Jan 25, 2023

/test pull-ingress-gce-test

@aojea
Copy link
Member Author

aojea commented Jan 25, 2023

/close

superseded by #1914

@k8s-ci-robot
Copy link
Contributor

@aojea: Closed this PR.

In response to this:

/close

superseded by #1914

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants