Clean up error state checking #1909
Conversation
|
Hi @sawsa307. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
a3dd0a8 to
61b85bb
Compare
|
/assign @swetharepakula |
|
/ok-to-test |
Consolidate EndpointSlice nodeName and zone check, and flip checking logic for better readability. Return error if nodeName or zone is missing when CalculateEndpoints, and check for error state based on the returned error. Add check for case when nodeName is set to be empty string. Flip invalid check to valid check.
|
/retest test failure is due to a prow error and not the PR |
61b85bb to
ee80ef9
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sawsa307, swetharepakula The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
Consolidate EndpointSlice nodeName and zone check, and flip checking logic for better readability.
Return error if nodeName or zone is missing when CalculateEndpoints, and check for error state based on the returned error. Add check for case when nodeName is set to be empty string. Flip invalid check to valid check.