Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Cherrypick #1828] l4 healthcheck timeouts change #1831

Merged
merged 1 commit into from
Oct 13, 2022
Merged

[Cherrypick #1828] l4 healthcheck timeouts change #1831

merged 1 commit into from
Oct 13, 2022

Conversation

code-elinka
Copy link
Contributor

@code-elinka code-elinka commented Oct 12, 2022 •
edited
Loading

This change cherry-picks functionality from master to the v1.14.8 to create a new patch v1.14.9 with changed healthcheck constants

According to l4 healthcheck constants
the default set up has timeout = 8 seconds
and threshold = 3 times. As result it can
lead to 24 (8*3) seconds of lost requests.
This change is supposed to decrease this
time to only 6 seconds for sharedHc=false.

Signed-off-by: Elina Akhmanova elinka@google.com

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 12, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @code-elinka. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 12, 2022
@code-elinka
Copy link
Contributor Author

/assign @panslava
/assign @cezarygerard

@panslava
Copy link
Contributor

Let's add in description that this cherry-picks one commit from the master, to create a special version

@code-elinka
Copy link
Contributor Author

Let's add in description that this cherry-picks one commit from the master, to create a special version

Done, @panslava

@cezarygerard
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 13, 2022
@cezarygerard
Copy link
Contributor

@code-elinka

please change the title of the PR:

[Cherrypick #1828] Change l4 healthcheck timeouts, cherry pick to v1.14

@code-elinka
[Cherrypick kubernetes#1828] l4 healthcheck timeouts change
093ba2c 
This change adds changed l4 healthcheck timeouts
to the v1.14 release.
According to l4 healthcheck constants
the default set up has timeout = 8 seconds
and threshold = 3 times. As result it can
lead to 24 (8*3) seconds of lost requests.
This change is supposed to decrease this
time to only 6 seconds for sharedHc=false.

Signed-off-by: Elina Akhmanova <elinka@google.com>
@code-elinka code-elinka changed the title Change l4 healthcheck timeout [Cherrypick #1828] l4 healthcheck timeouts change Oct 13, 2022
@cezarygerard
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 13, 2022
@cezarygerard
Copy link
Contributor

/approve

1 similar comment
@panslava
Copy link
Contributor

/approve

swetharepakula
swetharepakula reviewed Oct 13, 2022
View reviewed changes
Copy link
Member

@swetharepakula swetharepakula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cezarygerard, code-elinka, panslava, swetharepakula

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 13, 2022
@k8s-ci-robot k8s-ci-robot merged commit e9619cf into kubernetes:release-1.14 Oct 13, 2022
@code-elinka code-elinka deleted the release-1.14 branch August 10, 2023 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swetharepakula swetharepakula swetharepakula left review comments

@cezarygerard cezarygerard cezarygerard left review comments

@MrHohn MrHohn Awaiting requested review from MrHohn

@prameshj prameshj Awaiting requested review from prameshj

Assignees

@swetharepakula swetharepakula

@cezarygerard cezarygerard

@panslava panslava

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@code-elinka @k8s-ci-robot @panslava @cezarygerard @swetharepakula