Easier l4 hc - without singleton #1708
Conversation
- create a common singleton like struct fot l4 health checks - new struct holds mutex for common resources - delete shared healtcheck firewall rules safely
address review comments, improve tests, added mutex guard preventing re-initialization of L4 healhtchecks, renamed a few places, added comments It is important that all controllers in a single test case use the same fakeHC, I have fixed this in TestHealthCheckFirewallDeletionWithILB TestHealthCheckFirewallDeletionWithNetLB
address review comments, improve tests, added mutex guard preventing re-initialization of L4 healhtchecks, renamed a few places, added comments It is important that all controllers in a single test case use the same fakeHC, I have fixed this in TestHealthCheckFirewallDeletionWithILB TestHealthCheckFirewallDeletionWithNetLB
|
Hi @cezarygerard. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: cezarygerard The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
created on top of
#1705
this is just to show if removing singleton pattern from healthchecks gives any benefits