Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix http forwarding rule create workflow #1225

Merged
merged 1 commit into from
Aug 25, 2020
Merged

Bugfix http forwarding rule create workflow #1225

merged 1 commit into from
Aug 25, 2020

Conversation

skmatti
Copy link
Contributor

@skmatti skmatti commented Aug 25, 2020

Forwarding rule address needs to be reused when an ingress controller managed static IP address
exists for the ingress.

Fixes a bug introduced in #1126

/assign @rramkumar1 @freehan
cc @spencerhance

@skmatti
Bugfix http forwarding rule create workflow
284d027 
Forwarding rule address needs to be reused when
an ingress controller managed static IP address
exists for the ingress.
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 25, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @skmatti. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 25, 2020
@k8s-ci-robot k8s-ci-robot requested review from freehan and MrHohn August 25, 2020 05:09
@freehan
Copy link
Contributor

freehan commented Aug 25, 2020

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 25, 2020
@freehan
Copy link
Contributor

freehan commented Aug 25, 2020

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 25, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: freehan, skmatti

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 25, 2020
@k8s-ci-robot k8s-ci-robot merged commit ab712b3 into kubernetes:master Aug 25, 2020
skmatti added a commit to skmatti/ingress-gce that referenced this pull request Aug 25, 2020
@skmatti
Cherrypick kubernetes#1225[Bugfix http forwarding rule create workflo…
f49eaf9 
…w] into

release-10

Forwarding rule address needs to be reused when
an ingress controller managed static IP address
exists for the ingress.
@freehan
Copy link
Contributor

freehan commented Aug 25, 2020

/lgtm
/approve

k8s-ci-robot added a commit that referenced this pull request Aug 26, 2020
@k8s-ci-robot
Merge pull request #1226 from skmatti/cp-fw-fix
ff7d73d 
Cherrypick #1225[Bugfix http forwarding rule create workflow] into release-10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@freehan freehan Awaiting requested review from freehan

@MrHohn MrHohn Awaiting requested review from MrHohn

Assignees

@freehan freehan

@rramkumar1 rramkumar1

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@skmatti @k8s-ci-robot @freehan @rramkumar1