Merge pull request #2053 from sawsa307/cherry-pick-#2051-to-release-1.22

[Cherry pick #2051] Fix syncLock deadlock
kubernetes · Mar 31, 2023 · c49e853 · c49e853
2 parents 0b02f5f + b1dea8f
commit c49e853
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/pkg/neg/syncers/transaction.go b/pkg/neg/syncers/transaction.go
@@ -510,8 +510,8 @@ func (s *transactionSyncer) operationInternal(operation transactionOp, zone stri
 		s.recordEvent(apiv1.EventTypeWarning, operation.String()+"Failed", fmt.Sprintf("Failed to %s %d network endpoint(s) (NEG %q in zone %q): %v", operation.String(), len(networkEndpointMap), s.NegSyncerKey.NegName, zone, err))
 		if valid, reason := s.isValidEPBatch(err, operation, networkEndpoints); !valid {
 			s.syncLock.Lock()
-			defer s.syncLock.Unlock()
 			s.setErrorState(reason)
+			s.syncLock.Unlock()
 		}
 	}